`Either` deserializers `Option[T]` with value None as `null`

[ptrdom]

Jackson version 2.10.3.
Code to reproduce:

import com.fasterxml.jackson.module.scala.DefaultScalaModule

val right: Either[Option[String], Option[String]] = Right(None)
val left: Either[Option[String], Option[String]] = Left(None)

val mapper = new ObjectMapper()
mapper.registerModule(new DefaultScalaModule)

val rightString = mapper.writeValueAsString(right)
mapper.readValue(rightString, classOf[Either[Option[String], Option[String]]])

val leftString = mapper.writeValueAsString(left)
mapper.readValue(leftString, classOf[Either[Option[String], Option[String]]])

[ptrdom]

Apparently this is covered in tests as valid behavior:

jackson-module-scala/src/test/scala/com/fasterxml/jackson/module/scala/deser/EitherDeserializerTest.scala

Lines 29 to 37 in c29c398

	it should "be able to deserialize right with null value" in {
	deserialize[Either[_, String]](s"""{"r":null}""") should be (Right(null))
	deserialize[Either[_, String]](s"""{"right":null}""") should be (Right(null))
	}
	it should "be able to deserialize left with null value" in {
	deserialize[Either[String, String]](s"""{"l":null}""") should be (Left(null))
	deserialize[Either[String, String]](s"""{"left":null}""") should be (Left(null))
	}

That basically makes Either containing Option not possible. Is this really correct?

[pjfanning]

@dope9967 those tests are not specifically about Either wrapping Options - this looks like a use case that was not considered and it should ideally be fixed

Would you be able to try producing a Pull Request to fix this? 2.10 will not have any more releases. 2.11 is probably not a good place for a big change. I would suggest targeting the 2.12 branch.

[ptrdom]

@pjfanning sure, I can give it a try.

[pjfanning]

should be fixed in 2.12.0-SNAPSHOT now - I will backport to 2.11.3-SNAPSHOT in near future