Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default to true #725

Closed
pjfanning opened this issue Mar 5, 2025 · 2 comments
Closed

Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default to true #725

pjfanning opened this issue Mar 5, 2025 · 2 comments
Labels
3.x Issue planned for 3.x (and not 2.x)

Comments

@pjfanning
Copy link
Member

https://github.com/FasterXML/jackson-dataformat-xml/blob/master/src/main/java/tools/jackson/dataformat/xml/XmlWriteFeature.java#L45-L61

Comment says that we may be changing the default in 3.0
@pjfanning pjfanning added the 3.x Issue planned for 3.x (and not 2.x) label Mar 5, 2025
@cowtowncoder cowtowncoder changed the title change UNWRAP_ROOT_OBJECT_NODE default? Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default Mar 6, 2025
@cowtowncoder
Copy link
Member

Good catch @pjfanning ! Will do PR for change.

cowtowncoder added a commit that referenced this issue Mar 6, 2025
@cowtowncoder
Update ToXmlGenerator.Feature.UNWRAP_ROOT_OBJECT_NODE Javadoc wrt #725
578e628
@cowtowncoder cowtowncoder changed the title Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default to true (3.0) Mar 6, 2025
cowtowncoder added a commit that referenced this issue Mar 6, 2025
@cowtowncoder
Fix #725
419fdf6
@cowtowncoder cowtowncoder mentioned this issue Mar 6, 2025
Merged
@cowtowncoder cowtowncoder changed the title Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default to true (3.0) Change XmlWriteFeature.UNWRAP_ROOT_OBJECT_NODE default to true Mar 6, 2025
cowtowncoder added a commit that referenced this issue Mar 6, 2025
@cowtowncoder
Fix #725 (#726)
b892ac3
@cowtowncoder
Copy link
Member

Went ahead and changed 3 other defaults for #727, #728 and #729.

Can still re-consider if need be, based on feedback for 3.0.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Issue planned for 3.x (and not 2.x)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cowtowncoder @pjfanning