-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nesting depth in XmlReadContext
is not incremented/decremented on JsonToken.START_OBJECT/JsonToken.END_OBJECT
#657
Comments
@AlexUg Thank you for reporting this. Not a problem wrt PR, we can do that (plus specifically need to test this(. |
#609 is already open and describes why the nesting depth is not checked in jackson-dataformat-xml. TLDR is Woodstox can do the check. |
The "jackson-dataformat-xml" should not check nesting, but "jackson-dataformat-xml" should provide consumers with correct nesting information, as do the JSON and YAML parsers provided by "FasterXML" (to avoid violating interface specs - users expect correct information by calling 'parser.getParsingContext().getNestingDepth()' regardless of the parser type). |
True. There are some complexities here since nesting count will not necessarily be the same for logical content ( I am also not sure how easy it'd be to implement #609 over doing it on XML module side. |
XmlReadContext
is not incremented/decremented on JsonToken.START_OBJECT/JsonToken.END_OBJECT
Fixing tracking part as suggested, via #658. |
This bug can be fixed with below patch (just like it is implemented in 'com.fasterxml.jackson.core.json.JsonReadContext'):
Sorry for not creating a pull request...
The text was updated successfully, but these errors were encountered: