Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SubTypeValidator.DEFAULT_NO_DESER_CLASS_NAMES configurable #2463

Closed
dave-b-uk opened this issue Sep 19, 2019 · 1 comment
Closed

Make SubTypeValidator.DEFAULT_NO_DESER_CLASS_NAMES configurable #2463

dave-b-uk opened this issue Sep 19, 2019 · 1 comment
Labels
will-not-fix Closed as either non-issue or something not planned to be worked on

Comments

@dave-b-uk
Copy link

As more vulnerable gadgets are flagged as vulnerable, why not make the blacklist configurable? This would reduce the burden on consumers of the library to make sure they are not affected by changing the configuration in their projects

@dave-b-uk dave-b-uk changed the title Make SubTypeValidator.DEFAULT_NO_DESER_CLASS_NAMES configurable Make SubTypeValidator.DEFAULT_NO_DESER_CLASS_NAMES configurable Sep 19, 2019
@cowtowncoder
Copy link
Member

That would have been another possibility, but route taken for 2.10 was doing #2195 so that specific validator to use will be explicitly passed by users. Default implementation offers convenient base implementation for allow list (nee white-list) but not one for reverse, as fundamentally adding blocks will never cover all cases.

SubTypeValidator itself will eventually be removed (from 3.0 for sure I think), although for 2.x timeline it is probably best left as-is.

@cowtowncoder cowtowncoder added the will-not-fix Closed as either non-issue or something not planned to be worked on label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will-not-fix Closed as either non-issue or something not planned to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants