Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeTraversingParser.getLongValue() incorrectly checks canConvertToInt() #2393

Closed
RabbidDog opened this issue Jul 26, 2019 · 1 comment
Closed

TreeTraversingParser.getLongValue() incorrectly checks canConvertToInt() #2393

RabbidDog opened this issue Jul 26, 2019 · 1 comment
Milestone
2.10.0.pr2

Comments

@RabbidDog
Copy link

version 2.10.0.pr1

jackson-databind/src/main/java/com/fasterxml/jackson/databind/node/TreeTraversingParser.java

Line 315 in 6a88bc8

if (!node.canConvertToInt()) {

should check for canConvertToLong(). Instead checks for canConvertToInt() and throws "JsonMappingException"
@cowtowncoder
Copy link
Member

Good catch, thank you for reporting!

@cowtowncoder cowtowncoder changed the title getLongValue incorrectly checks canConvertToInt TreeTraversingParser.getLongValue() incorrectly checks canConvertToInt() Jul 26, 2019
@cowtowncoder cowtowncoder added this to the 2.10.0.pr2 milestone Jul 26, 2019
@janpachol janpachol mentioned this issue Jul 27, 2019
Closed
@cowtowncoder cowtowncoder mentioned this issue Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0.pr2
Development

No branches or pull requests
2 participants
@cowtowncoder @RabbidDog