Skip to content

Commit c647976

Browse files
committed
Merge branch '2.19'
2 parents db17b3e + f3fd6e2 commit c647976

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

release-notes/VERSION-2.x

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ Project: jackson-databind
7676
failure of `java.util.Optional` (de)serialization without Java 8 module
7777
#5014: Add `java.lang.Runnable` as unsafe base type in `DefaultBaseTypeLimitingValidator`
7878
#5020: Support new `@JsonProperty.isRequired` for overridable definition of "required-ness"
79+
#5052: Minor bug in `FirstCharBasedValidator.forFirstNameRule()`: returns `null`
80+
in non-default case
7981
8082
2.18.3 (28-Feb-2025)
8183

src/main/java/tools/jackson/databind/introspect/DefaultAccessorNamingStrategy.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,11 +455,11 @@ protected FirstCharBasedValidator(boolean allowLowerCaseFirstChar,
455455
* consider difference between "setter-methods" {@code setValue()} and {@code set_value()}.
456456
*
457457
* @return Validator instance to use, if any; {@code null} to indicate no additional
458-
* rules applied (case when both arguments are {@code false})
458+
* rules applied (case when both arguments are {@code true})
459459
*/
460460
public static BaseNameValidator forFirstNameRule(boolean allowLowerCaseFirstChar,
461461
boolean allowNonLetterFirstChar) {
462-
if (!allowLowerCaseFirstChar && !allowNonLetterFirstChar) {
462+
if (allowLowerCaseFirstChar && allowNonLetterFirstChar) {
463463
return null;
464464
}
465465
return new FirstCharBasedValidator(allowLowerCaseFirstChar,

0 commit comments

Comments
 (0)