And yet more refactoring for #668

Author: cowtowncoder

Diff for: src/main/java/tools/jackson/core/JacksonException.java

@@ -187,14 +187,65 @@ protected JacksonException(Throwable rootCause) {
     }
 
     protected JacksonException(String msg, Throwable rootCause) {
-        this(msg, null, rootCause);
+        this(null, msg, null, rootCause);
     }
 
     protected JacksonException(String msg, JsonLocation loc, Throwable rootCause) {
+        this(null, msg, loc, rootCause);
+    }
+
+    protected JacksonException(Closeable processor, Throwable rootCause) {
+        super(rootCause);
+        _processor = processor;
+        _location = _nonNullLocation(null);
+    }
+
+    protected JacksonException(Closeable processor, String msg, JsonLocation loc,
+            Throwable rootCause) {
         super(msg, rootCause);
-        _location = (loc == null) ? JsonLocation.NA : loc;
+        _processor = processor;
+        _location = _nonNullLocation(loc);
+    }
+    
+    protected JacksonException(Closeable processor, String msg)
+    {
+        super(msg);
+        _processor = processor;
+        JsonLocation loc = null;
+        if (processor instanceof JsonParser) {
+            // 17-Aug-2015, tatu: Use of token location makes some sense from databinding,
+            //   since actual parsing (current) location is typically only needed for low-level
+            //   parsing exceptions.
+            // 10-Jun-2024, tatu: Used from streaming too, current location possibly better
+            loc = ((JsonParser) processor).currentLocation();
+        }
+        _location = _nonNullLocation(loc);
     }
 
+    protected JacksonException(Closeable processor, String msg, Throwable problem)
+    {
+        super(msg, problem);
+        _processor = processor;
+        JsonLocation loc = null;
+        if (problem instanceof JacksonException) {
+            loc = ((JacksonException) problem).getLocation();
+        } else if (processor instanceof JsonParser) {
+            loc = ((JsonParser) processor).currentLocation();
+        }
+        _location = _nonNullLocation(loc);
+    }
+
+    protected JacksonException(Closeable processor, String msg, JsonLocation loc)
+    {
+        super(msg);
+        _processor = processor;
+        _location = _nonNullLocation(loc);
+    }
+
+    private static JsonLocation _nonNullLocation(JsonLocation loc) {
+        return (loc == null) ? JsonLocation.NA : loc;
+    }
+    
     // @since 3.0
     public JacksonException withCause(Throwable cause) {
         initCause(cause);

Diff for: src/main/java/tools/jackson/core/exc/StreamReadException.java

@@ -13,28 +13,23 @@ public class StreamReadException
 
     public StreamReadException(String msg) {
         super(msg);
-        _processor = null;
     }
 
     public StreamReadException(JsonParser p, String msg) {
-        super(msg, (p == null) ? null : p.currentLocation(), null);
-        _processor = p;
+        super(p, msg);
     }
 
     public StreamReadException(JsonParser p, String msg, Throwable root) {
-        super(msg, (p == null) ? null : p.currentLocation(), root);
-        _processor = p;
+        super(p, msg, root);
     }
 
     public StreamReadException(JsonParser p, String msg, JsonLocation loc) {
-        super(msg, loc, null);
-        _processor = p;
+        super(p, msg, loc);
     }
 
     public StreamReadException(JsonParser p, String msg, JsonLocation loc,
             Throwable rootCause) {
-        super(msg, loc, rootCause);
-        _processor = p;
+        super(p, msg, loc, rootCause);
     }
 
     /**

Diff for: src/main/java/tools/jackson/core/exc/StreamWriteException.java

@@ -12,18 +12,15 @@ public class StreamWriteException
     private final static long serialVersionUID = 3L;
 
     public StreamWriteException(JsonGenerator g, Throwable rootCause) {
-        super(rootCause);
-        _processor = g;
+        super(g, rootCause);
     }
 
     public StreamWriteException(JsonGenerator g, String msg) {
-        super(msg);
-        _processor = g;
+        super(g, msg);
     }
 
     public StreamWriteException(JsonGenerator g, String msg, Throwable rootCause) {
-        super(msg, null, rootCause);
-        _processor = g;
+        super(g, msg, rootCause);
     }
 
     /**