Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #12

Open
Farof opened this issue Jan 29, 2016 · 1 comment
Open

Tests #12

Farof opened this issue Jan 29, 2016 · 1 comment

Comments

@Farof
Copy link
Owner

Farof commented Jan 29, 2016

Identifying what areas would benefit from test coverage and writing them.

@jnovack
Copy link
Contributor

jnovack commented Jan 31, 2016

I propose a replay from every protocol along with the extract from that replay as verified against the heroprotocol python library.

Our tests would be then be to test extraction of that replay, and verify it against the extracted data already in the test/ directory. It bumps up the size of the repo considerably, but none of this goes in the npm package, so does it really matter?

The other option is to checksum the extracted files and only include the checksum in the tests.

Let me know, and I can get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants