Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettying up and modernizing the code #11

Open
Farof opened this issue Jan 29, 2016 · 4 comments
Open

Prettying up and modernizing the code #11

Farof opened this issue Jan 29, 2016 · 4 comments

Comments

@Farof
Copy link
Owner

Farof commented Jan 29, 2016

The direct port is ugly by JavaScript standards by moments, see about remedying to that with performance in mind.

@jnovack
Copy link
Contributor

jnovack commented Jan 30, 2016

So, we will not do an automated port then? Each new protocolXXXXX.js file found will have to be manually done?

@Farof
Copy link
Owner Author

Farof commented Jan 30, 2016

I very much want to automate it. I can see how both things can be incompatible. There's not much to pretty up in the protocols though, so anything done there could be done by the port automation as a lower priority objective.

@jnovack
Copy link
Contributor

jnovack commented Feb 1, 2016

There's a few forks of the upstream project already happening, one of which classes the code (as it should've done). I'd like to class the protocols since most of the constants and all of the functions are the same across protocol files, there's really only 2 values different.

@Farof
Copy link
Owner Author

Farof commented Feb 1, 2016

Looking at that for the port and reference automation. I'm also keeping an eye on what's happening upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants