Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create one Remapping Context per contextId provided by ModRemapper #16

Closed
thecatcore opened this issue Feb 25, 2025 · 0 comments · Fixed by #23
Closed

Create one Remapping Context per contextId provided by ModRemapper #16

thecatcore opened this issue Feb 25, 2025 · 0 comments · Fixed by #23
Labels
big feature high priority

Comments

@thecatcore
Copy link
Member

thecatcore commented Feb 25, 2025 •
edited
Loading

Currently ModRemappers all share the same remapping context, meaning only one source mapping is supported at a time.

The idea would be to have one remapper per ModRemapper which would imply those features:

  • ModRemapper filter which mods they are interested in.
  • ModRemapper can provide their own mappings without caring if another one use different mappings.
@thecatcore thecatcore changed the title Create a Remapping Context per ModRemapper Create one Remapping Context per ModRemapper Feb 25, 2025
@thecatcore thecatcore changed the title Create one Remapping Context per ModRemapper Create one Remapping Context per contextId provided by ModRemapper Apr 8, 2025
@thecatcore thecatcore mentioned this issue Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
big feature high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Api V2 FabricCompatibilityLayers/Mod-Remapping-API
1 participant
@thecatcore