implemented timeout in queue::pop, adding tests

Author: Adrian Mihai

readme.md

@@ -17,5 +17,6 @@ Sample Configuration:
     'project' => 'your-project-id',
     'queue'   => 'your-queue-name',
     'encrypt' => true,
+    'timeout' => 60
 ],
 ```

src/Connectors/IronConnector.php

@@ -60,6 +60,6 @@ public function connect(array $config)
             $iron->ssl_verifypeer = $config['ssl_verifypeer'];
         }
 
-        return new IronQueue($iron, $this->request, $config['queue'], $config['encrypt']);
+        return new IronQueue($iron, $this->request, $config['queue'], $config['encrypt'], $config['timeout']);
     }
 }

src/IronQueue.php

@@ -39,22 +39,29 @@ class IronQueue extends Queue implements QueueContract
      */
     protected $shouldEncrypt;
 
+    /**
+     * Number of seconds before the reservation_id times out on a newly popped message.
+     *
+     * @var int
+     */
+    protected $timeout;
+
     /**
      * Create a new IronMQ queue instance.
      *
-     * @param \IronMQ\IronMQ           $iron
+     * @param \IronMQ\IronMQ $iron
      * @param \Illuminate\Http\Request $request
-     * @param string                   $default
-     * @param bool                     $shouldEncrypt
-     *
-     * @return void
+     * @param string $default
+     * @param bool $shouldEncrypt
+     * @param int $timeout
      */
-    public function __construct(IronMQ $iron, Request $request, $default, $shouldEncrypt = false)
+    public function __construct(IronMQ $iron, Request $request, $default, $shouldEncrypt = false, $timeout = 60)
     {
         $this->iron = $iron;
         $this->request = $request;
         $this->default = $default;
         $this->shouldEncrypt = $shouldEncrypt;
+        $this->timeout = $timeout;
     }
 
     /**
@@ -135,7 +142,7 @@ public function pop($queue = null)
     {
         $queue = $this->getQueue($queue);
 
-        $job = $this->iron->reserveMessage($queue);
+        $job = $this->iron->reserveMessage($queue, $this->timeout);
 
         // If we were able to pop a message off of the queue, we will need to decrypt
         // the message body, as all Iron.io messages are encrypted, since the push

tests/IronQueueTest.php

@@ -75,7 +75,21 @@ public function testPopProperlyPopsJobOffOfIron()
         $crypt = m::mock('Illuminate\Contracts\Encryption\Encrypter');
         $queue->setEncrypter($crypt);
         $queue->setContainer(m::mock('Illuminate\Container\Container'));
-        $iron->shouldReceive('reserveMessage')->once()->with('default')->andReturn($job = m::mock('IronMQ_Message'));
+        $iron->shouldReceive('reserveMessage')->once()->with('default', 60)->andReturn($job = m::mock('IronMQ_Message'));
+        $job->body = 'foo';
+        $crypt->shouldReceive('decrypt')->once()->with('foo')->andReturn('foo');
+        $result = $queue->pop();
+
+        $this->assertInstanceOf('Collective\IronQueue\Jobs\IronJob', $result);
+    }
+
+    public function testPopProperlyPopsJobOffOfIronWithCustomTimeout()
+    {
+        $queue = new Collective\IronQueue\IronQueue($iron = m::mock('IronMQ\IronMQ'), m::mock('Illuminate\Http\Request'), 'default', true, 120);
+        $crypt = m::mock('Illuminate\Contracts\Encryption\Encrypter');
+        $queue->setEncrypter($crypt);
+        $queue->setContainer(m::mock('Illuminate\Container\Container'));
+        $iron->shouldReceive('reserveMessage')->once()->with('default', 120)->andReturn($job = m::mock('IronMQ_Message'));
         $job->body = 'foo';
         $crypt->shouldReceive('decrypt')->once()->with('foo')->andReturn('foo');
         $result = $queue->pop();
@@ -89,14 +103,31 @@ public function testPopProperlyPopsJobOffOfIronWithoutEncryption()
         $crypt = m::mock('Illuminate\Contracts\Encryption\Encrypter');
         $queue->setEncrypter($crypt);
         $queue->setContainer(m::mock('Illuminate\Container\Container'));
-        $iron->shouldReceive('reserveMessage')->once()->with('default')->andReturn($job = m::mock('IronMQ_Message'));
+        $iron->shouldReceive('reserveMessage')->once()->with('default', 60)->andReturn($job = m::mock('IronMQ_Message'));
         $job->body = 'foo';
         $crypt->shouldReceive('decrypt')->never();
         $result = $queue->pop();
 
         $this->assertInstanceOf('Collective\IronQueue\Jobs\IronJob', $result);
     }
 
+    public function testDeleteJobWithExpiredReservationIdThrowsAnException()
+    {
+        $queue = new Collective\IronQueue\IronQueue($iron = m::mock('IronMQ\IronMQ'), m::mock('Illuminate\Http\Request'), 'default', false, 30);
+        //$crypt = m::mock('Illuminate\Contracts\Encryption\Encrypter');
+        //$queue->setEncrypter($crypt);
+        //$queue->setContainer(m::mock('Illuminate\Container\Container'));
+        $iron->shouldReceive('deleteMessage')->with('default', 1, 'def456')->andThrow('IronCore\HttpException', '{"msg":"Reservation has timed out"}');
+
+        //$job->body = 'foo';
+        //$crypt->shouldReceive('decrypt')->never();
+        
+        // 'def456' refers to a reservation id that expired
+        $queue->deleteMessage('default', 1, 'def456');
+
+        //$this->assertInstanceOf('Collective\IronQueue\Jobs\IronJob', $result);
+    }
+
     public function testPushedJobsCanBeMarshaled()
     {
         $queue = $this->getMock('Collective\IronQueue\IronQueue', ['createPushedIronJob'], [$iron = m::mock('IronMQ\IronMQ'), $request = m::mock('Illuminate\Http\Request'), 'default', true]);