[Bug]: /rtp looks for locations twice

[ChiefArug]

Mod

FTB Essentials

Mod version

2101.1.4

NeoForge / Forge / Fabric version

Neo 21.1.92

Modpack & version

No response

What issue are you having?

/rtp fires findBlockPos twice and displays the text twice due to WarmupCooldownTeleporter calling positionGetter#apply twice.

First time here: FTBTeam/FTB-Essentials:common/src/main/java/dev/ftb/mods/ftbessentials/util/WarmupCooldownTeleporter.java#L64
to check if it is in a dimension blacklist.
Then the second time when it actually teleports, here: FTBTeam/FTB-Essentials:common/src/main/java/dev/ftb/mods/ftbessentials/util/WarmupCooldownTeleporter.java#L95
This also means the dimension blacklist doesn't function for /rtp.

Crashlogs

No response

Steps to reproduce

Run the /rtp command
Wonder how this got through testing

Anything else to note?

No response

[desht]

Yep, definitely not correct behaviour. The dest pos should only be computed a single time (also applies to other teleportation commands, although they're less critical, since /rtp is the only non-deterministic one).

This also means the dimension blacklist doesn't function for /rtp.

There's actually a separate blacklist for /rtp, which is checked as soon as the command is run - see teleportation/rtp/dimension_whitelist and dimension_blacklist in the config. Having said that, the global teleportation blacklists should also apply here, really.