Merge pull request #18 from FFXIV-CombatReborn/burst-button-crash

Fixes burst button crashing when clicked

Author: NostraThomas99

RotationSolver/UI/ControlWindow.cs

@@ -75,27 +75,52 @@ public override unsafe void Draw()
 
         var color = *ImGui.GetStyleColorVec4(ImGuiCol.TextDisabled);
 
-        var isAoe = Service.Config.UseAoeAction
-            && (!DataCenter.IsManual
-            || Service.Config.UseAoeWhenManual);
+        var isAoe = Service.Config.UseAoeAction && (!DataCenter.IsManual || Service.Config.UseAoeWhenManual);
+
+        // Track whether the style color was pushed
+        bool pushedStyleColor = false;
+
+        if (!isAoe)
+        {
+            ImGui.PushStyleColor(ImGuiCol.Text, color);
+            pushedStyleColor = true; // Indicate that a style color has been pushed
+        }
 
-        if (!isAoe) ImGui.PushStyleColor(ImGuiCol.Text, color);
         if (ImGuiHelper.SelectableButton("AOE"))
         {
             Service.Config.UseAoeAction.Value = !isAoe;
             Service.Config.UseAoeWhenManual.Value = !isAoe;
         }
-        if (!isAoe) ImGui.PopStyleColor();
+
+        // Ensure PopStyleColor is called only if PushStyleColor was called
+        if (pushedStyleColor)
+        {
+            ImGui.PopStyleColor();
+        }
+
 
         ImGui.SameLine();
 
         var isBurst = Service.Config.AutoBurst;
-        if (!isBurst) ImGui.PushStyleColor(ImGuiCol.Text, color);
+        // Track whether the style color was pushed
+        pushedStyleColor = false;
+
+        if (!isBurst)
+        {
+            ImGui.PushStyleColor(ImGuiCol.Text, color);
+            pushedStyleColor = true; // Indicate that a style color has been pushed
+        }
+
         if (ImGuiHelper.SelectableButton("Burst"))
         {
             Service.Config.AutoBurst.Value = !isBurst;
         }
-        if (!isBurst) ImGui.PopStyleColor();
+
+        // Ensure PopStyleColor is called only if PushStyleColor was called
+        if (pushedStyleColor)
+        {
+            ImGui.PopStyleColor();
+        }
         ImGui.SameLine();
         columnWidth = Math.Max(columnWidth, ImGui.GetCursorPosX());
         ImGui.NewLine();