Merge pull request #631 from FFXIV-CombatReborn/CODfix

Fix mixed up statuses for COD immunity

Author: LTS-FFXIV

ECommons

@@ -158,7 +158,7 @@ public ActionBasicInfo(IBaseAction action, bool isDutyAction)
         IsLimitBreak = (ActionCate?)_action.Action.ActionCategory.Value.RowId
             is ActionCate.LimitBreak or ActionCate.LimitBreak_15;
         IsDutyAction = isDutyAction;
-        //Aspect = (Aspect)_action.Action.Aspect; temporarily removing this line. Aspect was removed from lumina for some reason
+        //Aspect = (Aspect)_action.Action.Aspect; Resolved on next lumina update
     }
 
     internal readonly bool BasicCheck(bool skipStatusProvideCheck, bool skipComboCheck, bool skipCastingCheck)

RotationSolver.Basic/Actions/ActionBasicInfo.cs

@@ -523,8 +523,8 @@ public static bool IsCODBossImmune(this IBattleChara obj)
 
         var StygianStatus = StatusID.UnnamedStatus_4388;
         var CloudOfDarknessStatus = StatusID.VeilOfDarkness;
-        var AntiCloudOfDarknessStatus = StatusID.InnerDarkness;
-        var AntiStygianStatus = StatusID.OuterDarkness;
+        var AntiCloudOfDarknessStatus = StatusID.OuterDarkness;
+        var AntiStygianStatus = StatusID.InnerDarkness;
 
         if (obj.IsEnemy())
         {
@@ -533,7 +533,7 @@ public static bool IsCODBossImmune(this IBattleChara obj)
             {
                 if (Service.Config.InDebug)
                 {
-                    Svc.Log.Information("IsCODBossImmune: VeilOfDarkness status found, CloudOfDarkness immune");
+                    Svc.Log.Information("IsCODBossImmune: OuterDarkness status found, CloudOfDarkness immune");
                 }
                 return true;
             }
@@ -543,7 +543,7 @@ public static bool IsCODBossImmune(this IBattleChara obj)
             {
                 if (Service.Config.InDebug)
                 {
-                    Svc.Log.Information("IsCODBossImmune: UnnamedStatus4388 status found, Stygian immune");
+                    Svc.Log.Information("IsCODBossImmune: InnerDarkness status found, Stygian immune");
                 }
                 return true;
             }

RotationSolver.Basic/Helpers/ObjectHelper.cs

@@ -7,7 +7,7 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.12.0" />
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.13.0" />
 	</ItemGroup>
 
 	<ItemGroup>

RotationSolver.SourceGenerators/RotationSolver.SourceGenerators.csproj

@@ -179,7 +179,7 @@ internal static void UpdateRotationState()
                 if (playerObject == null)
                 {
                     if (Service.Config.InDebug)
-                        Svc.Log.Error("Player object is null.");
+                        Svc.Log.Information("Player object is null.");
                     return;
                 }