disallow write twice to 'estimate' and 'distribution' component (toml)

Author: B0SKAMP

api/src/main/java/org/fairdatapipeline/api/Object_component_write.java

@@ -64,6 +64,9 @@ public CleanableFileChannel writeFileChannel() throws IOException {
    * @param estimateNumber the number to write.
    */
   public void writeEstimate(Number estimateNumber) {
+    if(this.been_used) {
+      throw(new RuntimeException("obj component already written"));
+    }
     var estimate =
         ImmutableEstimate.builder().internalValue(estimateNumber).rng(this.dp.coderun.rng).build();
 
@@ -72,6 +75,7 @@ public void writeEstimate(Number estimateNumber) {
     } catch (IOException e) {
       throw (new RuntimeException("writeEstimate() -- IOException trying to write to file.", e));
     }
+    this.been_used = true;
   }
 
   /**
@@ -80,12 +84,16 @@ public void writeEstimate(Number estimateNumber) {
    * @param distribution the Distribution to write
    */
   public void writeDistribution(Distribution distribution) {
+    if(this.been_used) {
+      throw(new RuntimeException("obj component already written"));
+    }
     try (CleanableFileChannel fileChannel = this.getFileChannel()) {
       this.dp.coderun.parameterDataWriter.write(fileChannel, this.component_name, distribution);
     } catch (IOException e) {
       throw (new RuntimeException(
           "writeDistribution() -- IOException trying to write to file.", e));
     }
+    this.been_used = true;
   }
 
   /**

api/src/test/java/org/fairdatapipeline/api/CoderunIntegrationTest.java

@@ -325,6 +325,18 @@ void check_last_coderun(
     }
   }
 
+  @Test
+  @Order(1)
+  void testWriteEstimateFail() {
+    String dataProduct = "human/population2";
+    String component = "estimate-component";
+    try (Coderun coderun = new Coderun(configPath, scriptPath, token)) {
+      Data_product_write dp = coderun.get_dp_for_write(dataProduct, "toml");
+      Object_component_write oc = dp.getComponent(component);
+      oc.writeEstimate(estimate);
+      assertThrows(RuntimeException.class, () -> oc.writeEstimate(estimate));
+    }
+  }
   @Test
   @Order(1)
   void testWriteEstimate() {
@@ -381,6 +393,18 @@ void testReadDistribution() {
     check_last_coderun(List.of(new Triplet<>(dataProduct, component, hash)), null);
   }
 
+  @Test
+  @Order(5)
+  void testWriteCategoricalDistributionFail() {
+    String dataProduct = "human/cdistribution2";
+    String component = "cdistribution-component";
+    try (var coderun = new Coderun(configPath, scriptPath, token)) {
+      Data_product_write dp = coderun.get_dp_for_write(dataProduct, "toml");
+      Object_component_write oc = dp.getComponent(component);
+      oc.writeDistribution(categoricalDistribution);
+      assertThrows(RuntimeException.class, () -> oc.writeDistribution(distribution));
+    }
+  }
   @Test
   @Order(5)
   void testWriteCategoricalDistribution() {