Check file is not empty to prevent core dump

Author: RyanJField

src/utilities/data_io.cxx

@@ -23,6 +23,10 @@ toml::value read_data_from_toml(const ghc::filesystem::path file_path){
       throw toml_error("File '" + file_path.string() +
                               "' could not be opened as it does not exist");
     }
+  if (ghc::filesystem::is_empty(file_path)) {
+    throw toml_error("File '" + file_path.string() +
+                             "' appears to be empty");
+  }
 
   auto toml_data_ = toml::parse(file_path.string());
   return toml_data_;
@@ -95,6 +99,10 @@ std::string get_first_component(const ghc::filesystem::path &file_path){
     throw toml_error("File '" + file_path.string() +
                              "' could not be opened as it does not exist");
   }
+  if (ghc::filesystem::is_empty(file_path)) {
+    throw toml_error("File '" + file_path.string() +
+                             "' appears to be empty");
+  }
   const auto toml_data_ = toml::parse(file_path.string());
 
   return toml_data_.as_table().begin()->first;
@@ -105,6 +113,10 @@ bool component_exists(const ghc::filesystem::path &file_path, const std::string
   {
     return false;
   }
+  if (ghc::filesystem::is_empty(file_path)) {
+    throw toml_error("File '" + file_path.string() +
+                             "' appears to be empty");
+  }
   const auto toml_data_ = toml::parse(file_path.string());
   if(!toml_data_.contains(component)){
     return false;
@@ -115,4 +127,5 @@ bool component_exists(const ghc::filesystem::path &file_path, const std::string
   }
 
 }
+
 }; // namespace FairDataPipeline

test/test_io.cxx

@@ -184,10 +184,8 @@ TEST_F(IOTest, TestInvalidToml) {
     }     
 
     try{
-        ghc::filesystem::path empty_file( ghc::filesystem::path(TESTDIR) / "data" / "temp" / "empty_file.toml");
-        std::ofstream output_file;
-        output_file.open(empty_file.string());
-        output_file.close();
+        ghc::filesystem::path empty_file = ghc::filesystem::path(TESTDIR) / "data" / "temp" / "empty_file.toml";
+        std::ofstream output_file(empty_file.string());
         read_point_estimate_from_toml(empty_file);
         FAIL();
     }
@@ -199,6 +197,6 @@ TEST_F(IOTest, TestInvalidToml) {
     }
     catch(...){
         FAIL() << "Exception Thrown" << std::endl;
-    }     
+    }    
 
 }