Use a distinct empty state image for Spend > Expenses

[shawnborton]

Right now we are using the same folder illustration for both Spend > Expenses and Spend > Reports. Let's use a distinct image for Spend > Expenses so the product doesn't feel as monotonous for new users going through the various pages.

Issue Owner

Current Issue Owner: @dmkt9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dmkt9 (External)

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[shawnborton]

@MelvinBot can you create a proposal and implement? The new image to use is here: empty-state__expenses.svg.zip

It's the same dimensions as the existing Spend > Expenses empty state image.

[MelvinBot]

🤖 Created a draft PR that implements this: #99387

What it does

• Adds your new illustration as assets/images/product-illustrations/empty-state__expenses.svg (same 0 0 184 112 dimensions as the existing folder illustration).
• Registers it as EmptyStateSearchExpenses and exposes an expenses variant from useSearchEmptyStateIllustration.
• Swaps only the Spend > Expenses "no expenses yet" empty state (EmptySearchView.tsx:338) to use the new image. Spend > Reports keeps the existing FolderWithPapersAndWatch illustration, so the two pages are now distinct.

The generic "no results to show" states (e.g. when a filter matches nothing) intentionally keep the folder illustration — only the new-user empty state changed.

Verification

• npm run typecheck ✅
• ESLint on changed files ✅ (0 errors; one pre-existing grandfathered warning unrelated to this change)
• npm run react-compiler-compliance-check check ✅
• npm run spell-changed ✅
• Unit tests tests/ui/components/EmptySearchViewTest.tsx ✅ (9/9 passed)
• Ran npm run compress-svg so the asset matches the repo's SVG format.

Automated in-browser visual confirmation couldn't complete this run due to a blank-page session issue in the test harness (the dev server itself was healthy). The change is a static illustration swap covered by the unit suite above; please confirm the visual on the draft PR.

Please mark the PR as "Ready for review" when it looks good.

---

view run

[shawnborton]

Also @mallenexpensify this should be a relatively easy change, how do we knock the price down on this?