Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞The Stopping Staking Manager Recovery page is submittable with empty input #25

Open
glyv0x opened this issue Aug 20, 2020 · 2 comments
Labels
Improvement Proposal New feature or request

Comments

@glyv0x
Copy link

glyv0x commented Aug 20, 2020

Describe the bug

The Stopping Staking Manager Recovery page can be submitted without the Transaction Hash field getting filled out.

To Reproduce

  1. Go to a dapp page and navigate to DeFi/DeFi Offering.
  2. Press Stop.
  3. Scroll down and press Recovery.
  4. Scroll down again and submit without filling out anything.
  5. The page will now load and stop after a while.

Expected behavior

Ideally, the Start button should be disabled if the inputs are empty or an error should appear (without the long loading times).

Screenshots

ezgif com-video-to-gif

Web3 Scenario (please complete the following information):

  • Env.: Desktop
  • OS: macOS 10.15
  • Browser: Safari
  • Version: 13.1.2
  • Provider: Metamask

Reward

Discord Username and #: the4kman#4895
ETH Wallet: 0x0De8947c2ABd59C201e5EcE142bFCd22253BFC0d

@alet89 alet89 added the Improvement Proposal New feature or request label Sep 4, 2020
@alet89
Copy link

alet89 commented Sep 4, 2020

thank you to have opened this issue,

this is a design choice, because if you don't fill inputs everything works normally.

We made this choice, because users are able to fill just a recover input if they needs.

Have you some idea to improve the experience?

Issue From Bug to Improvement Proposal

@glyv0x
Copy link
Author

glyv0x commented Sep 6, 2020

@alet89 I would indicate somehow that the field is optional (for example, by adding the "(optional)" suffix to the placeholder text)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Proposal New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants