Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsck takes forever with a giant file #557

Open
EtchedPixels opened this issue Nov 14, 2017 · 1 comment
Open

fsck takes forever with a giant file #557

EtchedPixels opened this issue Nov 14, 2017 · 1 comment
Labels
enhancement Feature request Performance Speed rather than correctness impact

Comments

@EtchedPixels
Copy link
Owner

If we get a giant file we start walking all the blocks one by one patiently reading direct and indirect blocks to ascertain that yet again the block is a gap.

What we should do is spot that either the first or second indirect is 0 and skip on 256 blocks or 64K blocks by making getblkno also return the next viable candidate block to inspect.

@EtchedPixels EtchedPixels added enhancement Feature request Performance Speed rather than correctness impact labels Nov 14, 2017
@EtchedPixels
Copy link
Owner Author

Partly fixed by spotting re-reads of the same block. Really we want a 2 block cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request Performance Speed rather than correctness impact
Projects
None yet
Development

No branches or pull requests

1 participant