Skip to content

Switch to npm local paths #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gavinr opened this issue Jun 24, 2021 · 2 comments
Closed

Switch to npm local paths #873

gavinr opened this issue Jun 24, 2021 · 2 comments
Milestone

Comments

@gavinr
Copy link
Contributor

gavinr commented Jun 24, 2021

This article, discusses a more modern way to configure our package dependencies:

By introducing npm local paths, a lot of Lerna complex commands are no longer necessary to use. Plain old npm install suffice to setup the entire monorepo

Part 1 of this would be to update the dependencies in the package.json file for each package (for example here) per this example:

image

The next step would be to update the main package.json file to reference all the packages per this example:

image

Finally, after all these changes, we can now remove the lerna bootstrap step from the postinstall script since it's no longer necessary.

Just throwing this out there for initial feedback and comments. It seems like doing this is now the "more proper" way to do things, and in theory might speed up the npm install process.

@patrickarlt
Copy link
Contributor

@gavinr not sure if #911 handles this or not. You might want to take a look.

@patrickarlt patrickarlt added this to the v4.0 milestone Sep 8, 2021
@gavinr
Copy link
Contributor Author

gavinr commented Sep 8, 2021

I think #911 cleans things up in a different way, using the workspaces stuff, so let's close this for now and come back to it after the dust settles from the next major release if it still is applicable.

@gavinr gavinr closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants