Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give GroupFormElement a flat design #1032

Open
zkline101 opened this issue Jan 28, 2025 · 2 comments
Open

Give GroupFormElement a flat design #1032

zkline101 opened this issue Jan 28, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@zkline101
Copy link
Contributor

(Feedback from @PeggyDu09)
After the Form changes, I tried to achieve this but wasn't able to. Right now it looks like each group form element is grouped together when they should be separate.

Image

When it would look better with a flat design like this:

Image

So the goal would be to take out the background color from each disclosure group. I tried a few different ways to achieve this and none of them worked.

@zkline101 zkline101 added the enhancement New feature or request label Jan 28, 2025
@dfeinzimer
Copy link
Collaborator

@zkline101 I'm not sure I see the difference in the images above except for maybe the visibility of the Dividers and that the first uses two different font colors while the second uses only one.

My understanding is that the main issue with Form and GroupFormElement is that when the DisclosureGroup is expanded, there is no 2nd-level background color to connect each inner FieldFormElement visually. Is that a separate issue from this issue?

@zkline101
Copy link
Contributor Author

@zkline101 I'm not sure I see the difference in the images above except for maybe the visibility of the Dividers and that the first uses two different font colors while the second uses only one.

Yeah I guess it is hard to tell from the pictures. But for the first picture there is a background behind the form and the header of each disclosure group has a separate background. The second picture only shows the background behind the form and the header for each disclosure group doesn't have background color. Does that help?

My understanding is that the main issue with Form and GroupFormElement is that when the DisclosureGroup is expanded, there is no 2nd-level background color to connect each inner FieldFormElement visually. Is that a separate issue from this issue?

That sounds like a separate issue to me. The issue was surrounding the background color behind each disclosure group header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants