Fix opaque pointer core dump

Author: bytesnake

Cargo.lock

@@ -3897,6 +3897,7 @@ dependencies = [
  "rustc_middle",
  "rustc_session",
  "rustc_span",
+ "rustc_symbol_mangling",
  "rustc_target",
  "serde",
  "serde_json",

compiler/rustc_codegen_llvm/src/back/write.rs

@@ -23,7 +23,7 @@ use llvm::{
     LLVMCountParams, LLVMCountStructElementTypes, LLVMCreateBuilderInContext, LLVMDeleteFunction,
     LLVMDisposeBuilder, LLVMGetBasicBlockTerminator, LLVMGetElementType, LLVMGetModuleContext,
     LLVMGetParams, LLVMGetReturnType, LLVMPositionBuilderAtEnd, LLVMSetValueName2, LLVMTypeOf,
-    LLVMVoidTypeInContext,
+    LLVMVoidTypeInContext, LLVMGlobalGetValueType,
 };
 //use llvm::LLVMRustGetNamedValue;
 use rustc_codegen_ssa::back::link::ensure_removed;
@@ -694,8 +694,11 @@ pub(crate) unsafe fn enzyme_ad(
         ),
         _ => unreachable!(),
     };
-    let f_type = LLVMTypeOf(res);
-    let f_return_type = LLVMGetReturnType(LLVMGetElementType(f_type));
+    //let f_type = LLVMTypeOf(res);
+
+    let f_return_type = LLVMGetReturnType(LLVMGlobalGetValueType(res));
+
+    //let f_return_type = LLVMGetReturnType(LLVMGetElementType(f_type));
     let void_type = LLVMVoidTypeInContext(llcx);
     if item.attrs.mode == DiffMode::Reverse && f_return_type != void_type {
         //dbg!("Reverse Mode sanitizer");

compiler/rustc_codegen_llvm/src/llvm/ffi.rs

@@ -1133,6 +1133,7 @@ pub(crate) unsafe fn enzyme_rust_reverse_diff(
         1,                                        // vector mode width
         1,                                        // free memory
         Option::None,
+        0, // do not force anonymous tape
         dummy_type, // additional_arg, type info (return + args)
         args_uncacheable.as_ptr(),
         args_uncacheable.len(), // uncacheable arguments
@@ -1168,7 +1169,9 @@ extern "C" {
     pub fn LLVMGetFirstFunction(M: &Module) -> Option<&Value>;
     pub fn LLVMGetNextFunction(V: &Value) -> Option<&Value>;
     pub fn LLVMGetNamedFunction(M: &Module, Name: *const c_char) -> Option<&Value>;
+    pub fn LLVMGlobalGetValueType(val: &Value) -> &Type;
 
+    pub fn LLVMRustGetFunctionType(fnc: &Value) -> &Type;
     pub fn LLVMRustInstallFatalErrorHandler();
     pub fn LLVMRustDisableSystemDialogsOnCrash();
 
@@ -2813,6 +2816,7 @@ extern "C" {
         width: ::std::os::raw::c_uint,
         freeMemory: u8,
         additionalArg: Option<&Type>,
+        forceAnonymousTape: u8,
         typeInfo: CFnTypeInfo,
         _uncacheable_args: *const u8,
         uncacheable_args_size: size_t,

compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp

@@ -90,6 +90,11 @@ extern "C" char *LLVMRustGetLastError(void) {
   return Ret;
 }
 
+extern "C" LLVMTypeRef LLVMRustGetFunctionType(LLVMValueRef Fn) {
+    auto Ftype = unwrap<Function>(Fn)->getFunctionType();
+    return wrap(Ftype);
+}
+
 // Enzyme
 // extern "C" bool LLVMRustIsNull(LLVMValueRef V) {
 //   Value *Val = unwrap(V);

library/autodiff/examples/sin.rs

@@ -1,4 +1,3 @@
-#![feature(bench_black_box)]
 use autodiff::autodiff;
 
 #[autodiff(cos_inplace, Reverse, Const)]

library/autodiff/examples/vec.rs

@@ -1,16 +1,17 @@
 #![feature(bench_black_box)]
 use autodiff::autodiff;
 
-#[autodiff(d_sum, Reverse, Active)]
+#[autodiff(d_sum, Forward, Duplicated)]
 fn sum(#[dup] x: &Vec<Vec<f32>>) -> f32 {
     x.into_iter().map(|x| x.into_iter().map(|x| x.sqrt())).flatten().sum()
 }
 
 fn main() {
     let a = vec![vec![1.0, 2.0, 4.0, 8.0]];
-    let mut b = vec![vec![0.0, 0.0, 0.0, 0.0]];
+    //let mut b = vec![vec![0.0, 0.0, 0.0, 0.0]];
+    let b = vec![vec![1.0, 0.0, 0.0, 0.0]];
 
-    d_sum(&a, &mut b, 1.0);
+    dbg!(&d_sum(&a, &b));
 
     dbg!(&b);
 }