refactor a little bit

iynehz · iynehz · commit 6ff41069b7e9 · 2021-11-27T21:45:23.000+08:00
diff --git a/lib/Data/Frame/Util.pm b/lib/Data/Frame/Util.pm
@@ -164,10 +164,8 @@ fun guess_and_convert_to_pdl ( (ArrayRef | Value | ColumnLike) $x,
           $strings_as_factors
           ? PDL::Factor->new($x)
           : PDL::SV->new($x);
-        my @is_bad = List::AllUtils::indexes { &$is_na($_) } @$x;
-        if (@is_bad) {
-            $piddle = $piddle->setbadif( pdl( \@is_bad ) );
-        }
+        my $is_bad = pdl( [ map { &$is_na($_) } @$x ] );
+        $piddle = $piddle->setbadif($is_bad);
         return $piddle;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -164,10 +164,8 @@ fun guess_and_convert_to_pdl ( (ArrayRef \| Value \| ColumnLike) $x,`
`164`	`164`	`$strings_as_factors`
`165`	`165`	`? PDL::Factor->new($x)`
`166`	`166`	`: PDL::SV->new($x);`
`167`		`- my @is_bad = List::AllUtils::indexes { &$is_na($_) } @$x;`
`168`		`- if (@is_bad) {`
`169`		`- $piddle = $piddle->setbadif( pdl( \@is_bad ) );`
`170`		`- }`
	`167`	`+ my $is_bad = pdl( [ map { &$is_na($_) } @$x ] );`
	`168`	`+ $piddle = $piddle->setbadif($is_bad);`
`171`	`169`	`return $piddle;`
`172`	`170`	`}`
`173`	`171`	`}`