Skip to content

Commit 5c2e9a5

Browse files
committed
UPDATE for a batch of grammar and formatting improvements
1 parent 218270f commit 5c2e9a5

7 files changed

+148
-150
lines changed

Knowledge base/CLI_Setup.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
3. [> Unable to find image 'asia-docker.pkg.dev/supra-devnet/misc/supra-testnet/validator-node:v6.3.0' locally](#ISSUE-SUMMARY-Unable-to-find-image)
55
4. [> Supra equivalent command for create-resource-account-and-publish-package](#ISSUE-SUMMARY-Supra-equivalent-command-for)
66
5. [> Not able to locate MOVE.Toml file](#issue-summary-trouble-for-seeing-movetoml-file-at-local-but-only-on-docker-container-files)
7-
7+
88
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
99

1010
NOTE: Follow the format below to get started with reporting the issues!
1111
- `ISSUE SUMMARY`
12-
- `SOLUTION SUMMARY`
12+
- `SOLUTION SUMMARY`
1313

1414
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
1515

@@ -29,9 +29,9 @@ supra
2929
- Open Docker Desktop and ensure the container is active, or
3030
- Run the following command:
3131

32-
```PowerShell
33-
docker ps
34-
```
32+
```PowerShell
33+
docker ps
34+
```
3535

3636
Ensure the supra_cli container is listed as running.
3737

@@ -109,4 +109,4 @@ docker run --name supra_cli -v ${PWD}:/supra/configs/<PATH LINK> -e SUPRA_HOME=/
109109

110110
Also for Move.toml issue, the one in the local project folder has to be the same as the Move.toml file in your Docker container.
111111

112-
Click on supra container > files > Supra folder > config > Move workspace > check the move.toml file via code editor and make sure it has the same address and dependencies.
112+
Click on supra container > files > Supra folder > config > Move workspace > check the move.toml file via code editor and make sure it has the same address and dependencies.

Knowledge base/Module and Deployment.md

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ The code snippet in here demonstrate that how can we create tx payload for entry
2525

2626
So we should convert the move function call to rawTransaction object and pass it to the data that defined on your docs, and we ignore the sequence_number like metamask ignore the nonce and the wallet side will process that.
2727

28-
For raw transaction, Process to create a `rawTx` and `serializedRawTx` is almost similar
28+
For raw a transaction, the process to create a `rawTx` and `serializedRawTx` is almost similar
2929

30-
```PowerShell
30+
```TypeScript
3131
// To send serialized transaction
3232
console.log(
3333
await supraClient.sendTxUsingSerializedRawTransaction(
@@ -38,22 +38,22 @@ For raw transaction, Process to create a `rawTx` and `serializedRawTx` is almost
3838
enableWaitForTransaction: true,
3939
}
4040
)
41-
);
41+
);
4242
```
4343
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
44-
## ISSUE SUMMARY: sign a message using starkey wallet
45-
### Couldn't find any docs regarding sign a message using starkey wallet, any example code that I can start with?
44+
## ISSUE SUMMARY: Sign a message using Starkey Wallet
45+
### Couldn't find any docs regarding sign a message using Starkey Wallet, any example code that I can start with?
4646

4747
### ➥ SOLUTION SUMMARY:
4848
Please update to Min V 1.1.24, This Version and Above includes the signMessage function.
49-
Here's a code snippet for the help:
49+
Here's a code snippet for the help:
5050

5151
```Javascript
5252
// Javascript
5353
import nacl from "tweetnacl";
5454

55-
const haxString = '0x' + Buffer.from(signMessage, 'utf8').toString('hex')
56-
const response = await supraProvider.signMessage({message:haxString})
55+
const hexString = '0x' + Buffer.from(signMessage, 'utf8').toString('hex')
56+
const response = await supraProvider.signMessage({message:hexString})
5757
console.log('signMessage response :: ', response)
5858
if (response) {
5959
const { publicKey,signature,address } = response
@@ -71,15 +71,15 @@ console.log('signMessage response :: ', response)
7171

7272
```Typescript
7373
// Typescript
74-
const remove0xPrefix = (hexString: string) => {
75-
return hexString.startsWith("0x") ? hexString.slice(2) : hexString;
76-
}
74+
const remove0xPrefix = (hexString: string) => {
75+
return hexString.startsWith("0x") ? hexString.slice(2) : hexString;
76+
}
7777
```
7878
Demo LINK: https://frontend-web-wallet-connect-demo.vercel.app/supra-dapp
7979

8080
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
8181
## ISSUE SUMMARY: Error Code 0x1::resource_account: 0x60001
82-
Getting error in deploying the contract to testnet while the contracts are build without any error and error code in output is 0x1::resource_account: 0x60001
82+
Getting error in deploying the contract to testnet while the contracts are built without any error and error code in output is 0x1::resource_account: 0x60001
8383

8484
### ➥ SOLUTION SUMMARY:
8585
This error message typically indicates a problem with resource account management within the Move code. In the context of deploying a contract, it likely means that there's an issue with how your contract interacts with the resource accounts.
@@ -92,13 +92,13 @@ https://github.com/Entropy-Foundation/aptos-core/blob/b414eadb54e8e8722e58096f96
9292

9393
It means the container resource that stores the mapping of the resource address to signer capability doesn't exist at the address you are passing
9494

95-
Here is a repo that I used to test the create_resource_account_and_publish_package method
95+
Here is a repo that I used to test the create_resource_account_and_publish_package method
9696
https://github.com/nolan-supra/TS-SDK_Create-Resource-Account-And-Publish-Package
9797

9898
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
9999
## ISSUE SUMMARY: Move compilation failed: supra move tool compile
100100

101-
Move compilation failed while doing `supra move tool compile --package-dir /supra/configs/move_workspace/PROJECT NAME`
101+
Move compilation failed while doing `supra move tool compile --package-dir /supra/configs/move_workspace/PROJECT NAME`
102102

103103
Error message
104104
```PowerShell
@@ -118,7 +118,7 @@ Add the dependency like this
118118
```
119119
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
120120
## ISSUE SUMMARY: Call the Modules Deployed on Supra
121-
An example code or like repo to Call the Modules Deployed on Supra.
121+
An example code or like repo to Call the Modules Deployed on Supra.
122122

123123
## ➥ SOLUTION SUMMARY:
124124
All of our deployed framework modules are available in the framework folder of the github repo then api endpoint can be used to see which modules are available.
@@ -134,7 +134,7 @@ https://rpc-testnet.supra.com/rpc/v1/accounts/{address}/modules/{module_name}
134134
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
135135
## ISSUE SUMMARY: Digital Assets Dependency for NFT Dapp
136136

137-
### ➥ SOLUTION SUMMARY:
137+
### ➥ SOLUTION SUMMARY:
138138
these digital assets modules are deployed at the 0x4 address
139139

140140
```PowerShell
@@ -153,12 +153,12 @@ https://rpc-mainnet.supra.com/rpc/v1/accounts/0x4/modules
153153
**src:** https://github.com/Entropy-Foundation/aptos-core/blob/dev/aptos-move/framework/aptos-token-objects/sources/token.move
154154

155155
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
156-
## ISSUE SUMMARY: Module for Implementation on a custom coin.
156+
## ISSUE SUMMARY: Module for Implementation on a custom coin.
157157

158-
### ➥ SOLUTION SUMMARY:
158+
### ➥ SOLUTION SUMMARY:
159159
A Move Module Made for a liquid swap on supra, Customize and use this to work for your Implementation on a custom coin:
160160

161-
```PowerShell
161+
```Move
162162
module airdrop_deployer::bitcoin_coin {
163163
use std::error;
164164
use std::signer;
@@ -211,7 +211,7 @@ module airdrop_deployer::bitcoin_coin {
211211
coin::deposit(signer::address_of(user), coins);
212212
}
213213
}
214-
```
214+
```
215215

216216
More details on what's happening here:
217217

@@ -222,11 +222,11 @@ More details on what's happening here:
222222
5. The module ensures strict access control and leverages Move's resource model for safe and efficient token management.
223223

224224
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
225-
## ISSUE SUMMARY: transfer function stating that account isn't registered
225+
## ISSUE SUMMARY: Transfer function stating that account isn't registered
226226
We are creating a token and then registering our account to have a coinstore for that token, it’s still reverting back on transfer function stating that account isn't registered.
227227

228-
### ➥ SOLUTION SUMMARY:
229-
The error `account isn't registered` during the transfer function indicates that the recipient address hasn't been registered with the coin module.
228+
### ➥ SOLUTION SUMMARY:
229+
The error `account isn't registered` during the transfer function indicates that the recipient address hasn't been registered with the coin module.
230230

231231
Before like having token transfer and all ensure the recipient address is explicitly registered using the `register` function and If your token design allows for implicit registration, the `transfer` function could potentially register the recipient if they're not already registered. However, this might have security implications and should be carefully considered.
232232

@@ -236,10 +236,10 @@ You can check that the `coin module` is accessible to the `transfer` function. E
236236
## ISSUE SUMMARY: Calling Supra Coin
237237
From Supraframework do we have supra coins?
238238

239-
## ➥ SOLUTION SUMMARY:
239+
## ➥ SOLUTION SUMMARY:
240240

241241
Yes,
242242
Use below call for calling Supra coin for the framework
243-
```PowerShell
243+
```Move
244244
use supra_framework::supra_coin;
245-
```
245+
```

Knowledge base/Oracles_and_VRF_Errors.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Table of Contents
22
1. [> If a request fails on callback, is there a time-delay before it is retried?](#issue-summary-if-a-request-fails-on-callback-is-there-a-time-delay-before-it-is-retried)
3-
2. [> Time period For Request tobe permanently dropped](#issue-summary-time-period-for-request-tobe-permanently-dropped)
4-
3. [> Callback due to Insufficient Fund](#issue-summary--callback-due-to-insufficient-fund)
3+
2. [> Time period For Request to be permanently dropped](#issue-summary-time-period-for-request-tobe-permanently-dropped)
4+
3. [> Callback due to Insufficient Funds](#issue-summary--callback-due-to-insufficient-fund)
55
4. [> Pull Oracles are returning 404](#issue-summary-pull-oracles-are-returning-404)
66
5. [> Whitelisting Note for dVRF.](#issue-summary-whitelisting-note-for-dvrf)
77

@@ -17,22 +17,22 @@ NOTE: Kindly follow the below format to get started with reporting the issues!
1717

1818
### ➥ SOLUTION SUMMARY:
1919
Depends on the type of failure. There can be a lot of reasons for the failure.
20-
If the client has insufficient balance then its going to get failed after 3 retries from each primary and backup. So we send multiple emails alerts before the client balance reaches minBalance.
20+
If the client has insufficient balance then its going to get failed after 3 retries from each primary and backup. So we send multiple emails alerts before the client balance reaches minBalance.
2121
If the delay is because of txn not getting confirmed yet and still in the mempool (because of the gas price) then we do retry twice with a span of 3 mins from each primary and backup.
2222
If the failure is because of some revert actions present in the client contract then we provide proper events to tranck them.
2323

2424
NOTE:: Backup node works 15 blocks behind primary
2525

2626
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
27-
## ISSUE SUMMARY: Time period For Request tobe permanently dropped
28-
Is there a time window where, after a certain amount of retries or some time period, the request is permanently dropped?
27+
## ISSUE SUMMARY: Time period For Request to be permanently dropped
28+
Is there a time window where, after a certain amount of retries or some time period, the request is permanently dropped?
2929

3030
### ➥ SOLUTION SUMMARY:
3131
No specific time window in this version that will be available in the next version.
3232

3333
![-----------------------------------------------------](https://raw.githubusercontent.com/andreasbm/readme/master/assets/lines/rainbow.png)
3434

35-
## ISSUE SUMMARY: Callback due to Insufficient Fund
35+
## ISSUE SUMMARY: Callback due to Insufficient Funds
3636
If Chainlink ever fails its callback (due to insufficient funds or whatever the case may be), we're able to rescue funds from the game contract itself, knowing that after 24 hours, that specific request will never try to callback again. I was wondering if we had any guarantees in this way for Supra, so we know how to handle an event of something going wrong.
3737

3838
### ➥ SOLUTION SUMMARY:

Knowledge base/Other_Configuration_Errors.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ NOTE: Kindly follow the below format to get started with reporting the issues!
1111

1212
## ISSUE SUMMARY: Extract an address using a private key
1313

14-
For some reason, when I try to extract an address using a private key, for example, with ethereum, everything works correctly in testnet, but when I take the supra private key, I get a different address, not the one indicated in the application, they even differ in length, it is still very problematic with it, maybe the library is not suitable and maybe they have some kind of library for working with supra.
14+
For some reason, when I try to extract an address using a private key, for example, with Ethereum, everything works correctly in testnet, but when I take the supra private key, I get a different address, not the one indicated in the application, they even differ in length, it is still very problematic with it, maybe the library is not suitable and maybe they have some kind of library for working with supra.
1515

16-
### ➥ SOLUTION SUMMARY:
16+
### ➥ SOLUTION SUMMARY:
1717
The discrepancy you're encountering between Ethereum and Supra address derivation likely from fundamental differences in both chain's underlying cryptographic algorithms and address formats, you wanna look at the library again, eth addresses are 160bit, Supra has 256.

0 commit comments

Comments
 (0)