Skip to content

Commit e20794e

Browse files
authored
comments on documentation (#17)
Co-authored-by: Owolabi Legunsen <[email protected]>
1 parent 7e7b05f commit e20794e

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

doc/design.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ Key design goal: Implement everything using functions and files (i.e.,
66
there is no need to change existing shells or existing user code).
77

88
As the result, a user can adopt gobash as needed without being forced
9-
to rewrite any of their code, but can benefit by using some/all of
10-
gobash features, which can be introduced gradually. Additionally,
11-
gobash should work with any `bash` version and OS that runs `bash`.
9+
to rewrite any of their code. Rather, a user can benefit by using
10+
some/all of gobash features, which can be introduced gradually.
11+
Additionally, gobash should work with any `bash` version and OS that
12+
runs `bash`.
1213

1314
.. toctree::
1415
:maxdepth: 2

doc/get-started.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ Clone the gobash repository:
2929
3030
git clone [email protected]:EngineeringSoftware/gobash
3131
32-
Alternatively, you can avoid cloning the repo and directly source the
33-
library in your bash script:
32+
Alternatively, you can avoid cloning the repo and directly `source`
33+
the library in your bash script:
3434

3535
.. code-block:: bash
3636
@@ -107,8 +107,8 @@ In the following example (`point.sh`), we introduce a `struct` for a
107107
Test Example
108108
------------
109109

110-
This example illustrate a way to write tests using a testing package.
111-
The tests can be executed with the gobash tool.
110+
This example illustrates a way to write tests using gobash's testing
111+
package. The tests can be executed with the gobash tool.
112112

113113
We will extend the previous example to add tests (`point_test.sh`) for
114114
the function `point_add`.
@@ -134,7 +134,7 @@ Tests can be run with the following command:
134134
135135
./gobash test --paths point_test.sh --verbose
136136
137-
The output of this execution will be along these lines:
137+
The output of this execution will look like this:
138138

139139
.. code-block:: bash
140140
@@ -151,7 +151,7 @@ There are a number of other examples that illustrate gobash in the
151151
`examples directory
152152
<https://github.com/EngineeringSoftware/gobash/tree/main/examples/README.md>`_.
153153
If you like learning by examples, that is the best place to go next.
154-
If you prefer to read higher level doc, then check
154+
If you prefer to read higher level documentation, then check
155155
:doc:`language`.
156156

157157
.. toctree::

doc/index.rst

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@ gobash is a set of bash functions that improve programming experience
66
in bash (by providing collections, languages features, APIs, testing
77
package, command line flag parsing, etc.) without modifying the shell
88
interpreter(s). It works with any bash version (on Linux and
9-
Mac). Parts of the API are matching those in Go.
9+
Mac). Parts of the API match those in Go.
1010

1111
gobash is publicly available on `GitHub
1212
<https://github.com/EngineeringSoftware/gobash>`_ under the
1313
`BSD-3-Clause license
14-
<https://github.com/EngineeringSoftware/gobash/blob/main/LICENSE>`_.
14+
<https://github.com/EngineeringSoftware/gobash/blob/main/LICENSE>`_. The
15+
dependencies needed to run gobash are listed on that GitHub page.
1516

16-
Here is a quick example that uses gobash (but check later sections for
17-
a lot more):
17+
Here is a quick example that uses gobash (check later sections for
18+
more):
1819

1920
.. code-block:: bash
2021

doc/motivation.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@ of the scripting has moved over to Python (and a few other languages)
1010
due to availability of (standard) libraries and testing support.
1111
However, seeing `import subprocess; subprocess.run(["ls", "-l"])` or
1212
similar code in Python, and then using replacements for `awk`, `sed`,
13-
`grep`, `git` commands (and awkwardly processing their outputs) never
14-
looks very exciting.
13+
`grep`, `git` commands (and awkwardly processing their outputs)
14+
suggests that developers may use bash more if it had better libraries
15+
and testing support.
1516

1617
Key motivation points:
1718

1819
* Provide a "standard" library for bash
19-
* Provide missing language features (but do not design new language or change interpreters)
20+
* Provide missing language features (without designing a new language or changing interpreters)
2021
* Enable using the same set of functions across various operating systems
2122
* Enable using different interpreters (and their versions) by hiding details behind APIs
2223

0 commit comments

Comments
 (0)