crc16 is using internal crc with 32 bit size

[amgross]

erpc/erpc_c/infra/erpc_crc16.cpp

Lines 32 to 38 in 60a3cc1

	uint32_t crc = m_crcStart;
	uint32_t j;
	uint32_t i;
	uint32_t byte;
	uint32_t temp;
	const uint32_t andValue = 0x8000U;
	const uint32_t xorValue = 0x1021U;

Maybe I am missing something.
Why can't the variables crc, temp, andValue , xorValue be uint32_t and byte be uint8_t ?
It makes things cleaner and I don't see it effects the algorithm

[Hadatko]

Hi @amgross , so only change you are suggesting is change byte to uint8_t correct?
I am not against it but we need be carefull. I think "byte<<8" can do undefined behavior. Compiler can throw away one byte. So we need recast it then ((uint16_t)(byte)) << 8

[amgross]

Oops, I wrote wrong, I mean:
Why can't the variables crc, temp, andValue , xorValue be uint16_t

[amgross]

About byte<<8,
Please see https://stackoverflow.com/questions/69143163/c-uses-different-data-type-for-arithmetic-in-the-middle-of-an-expression .
byte<<8 is equivalent to ((unsigned int)byte)<<8