Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.5] Players' TP requests can be saved, causing the JSON parser to crash the server #22

Open
vabold opened this issue Dec 28, 2024 · 0 comments

Comments

@vabold
Copy link

vabold commented Dec 28, 2024

If the following is found within a pdat file for someone's UUID:

  "tpRequest": {
    "requester": "request_uuid",
    "target": "target_uuid",
    "tpHere": false // can be either
  },

The JSON method cannot instantiate the ITpRequest in the PlayerData. This causes the server to disconnect the player with an internal server error, which then causes the same error on player leave, which crashes the server.

A band-aid solution for server maintainers is to simply remove these lines from the player's UUID whenever this happens. (This can be automated as a step before server launch, so crashes only happen once.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant