Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor performance when many commands are available #15

Open
LucilleTea opened this issue Jan 16, 2023 · 1 comment
Open

Poor performance when many commands are available #15

LucilleTea opened this issue Jan 16, 2023 · 1 comment

Comments

@LucilleTea
Copy link

LucilleTea commented Jan 16, 2023

One of my mods, forgery, adds about 8k commands as recognized by serverutils - enough to configure the mod entirely.
Since adding this mod to the server, there is a huge ~20 second lag spike whenever a player connects, switches dimensions or respawns. Spark analysis shows the server is spending a long time filtering then reapplying all permissions to the player, and spark's GC monitor showed over 800mb/s being freed during this time.

I'm not sure if this lag applies equally to ops and default rank players. I suppose the commands have to be filtered either way, but the spike seemed much smaller when some unranked players did these actions. However removing op rank (and vanilla status) from myself doesn't reduce the issue. Maybe something else eg. latency exacerbates it? Or something's cached poorly? Can't say, but I can provide the info I do have:

https://cdn.discordapp.com/attachments/622089187809820672/1064550148098760764/Permissions.json
https://spark.lucko.me/7sOxwVHrG6

Using server_utils-1.16.5-2.8.0

@LucilleTea
Copy link
Author

LucilleTea commented Jan 16, 2023

Update: the lag persisted for me because i had the * permission applied to myself as well as the op rank. I think this issue relates to actually applying permissions to players, and default rank players lag the server less in this situation. The problem is not fixed, ops still lag the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant