[BUG] Flickering textures when Oculus is installed

[ACCBDD]

Versions:

• Forge 47.3.11
• Nature's Aura 39.4
• Oculus 1.7.0

Issue:
When both Oculus and Nature's Aura is installed, certain textures start to flicker and z-fight in certain cases, most notably water. This is a known issue on the Oculus tracker, and apparently they think it's something to do with the particle handler changing the OpenGL state and not resetting it?

Workaround:
This can be fixed by going into the config and setting particles to 0 - obviously this isn't ideal!

[ACCBDD]

After doing some testing, it looks like this is because the particle handler disables culling and never re-enables it - this means that water gets rendered twice (along with basically anything else that uses backface culling, like flowers!)

Without the fix:
2024-12-09 19-49-52.webm

With the fix:
2024-12-09 19-51-45.webm

I've fixed the bug in a fork, but I'm not sure how to pull request it into this repo. I can send you updated binaries for 1.20.1?

[Ellpeck]

Hi, thanks so much for investigating this issue! Unfortunately, Minecraft 1.20 is not supported anymore except for major or gamebreaking bugs. Please check to make sure if this issue still happens in recent versions of Nature's Aura if you can.

[ACCBDD]

Hello! I can't reproduce the bug in recent versions of Nature's Aura - however, this is a bug that is both very easily fixable and very annoying in my modpack. I understand if you don't want to add this fix, though - in the worst case, I'll just make a small mixin mod to fix it.