Expose a Channel's Routing Fee Setting via `listpeers`

[niftynei]

lt'd be handy to know what the feerate we're broadcasting for any particular channel is via the channel listing in listpeers.

[darosior]

This time I'm sure, you can use listchannels on your scid and use the base_fee_millisatoshi and fee_per_millionth.
EDIT: However, as an user it's a really long task to inspect fees with >10 channels and I dreamed about an extension to summary which would include the fees for a quick overview :).

[niftynei]

Yes, I think this can best be understood as a request to add it to listpeers. Will update description

[shinghim]

When I run lightning-cli listpeers, I get something like this:

{
   "peers": [
      {
         "id": xxxxx,
         "connected": true,
         "netaddr": [
            xxxxx
         ],
         "features": xxxxx,
         "channels": [
            {
               "state": "CHANNELD_NORMAL",
               "scratch_txid": xxxxx,
               "last_tx_fee": xxxxx,
               "last_tx_fee_msat": xxxxx,
               ...
               "out_msatoshi_fulfilled": xxxxx,
               "out_fulfilled_msat": xxxxx,
               "htlcs": []
            }
         ]
      }
   ]
}

Is this the goal of this feature to add attributes so the output from lightning-cli listpeers will look something like this:

{
   "peers": [
      {
         "id": xxxxx,
         "connected": true,
         "netaddr": [
            xxxxx
         ],
         "features": xxxxx,
         "channels": [
            {
               "state": "CHANNELD_NORMAL",
               "scratch_txid": xxxxx,
               "last_tx_fee": xxxxx,
               "last_tx_fee_msat": xxxxx,
               ...
               "out_msatoshi_fulfilled": xxxxx,
               "out_fulfilled_msat": xxxxx,
               "htlcs": []

               "base_fee_millisatoshi": xxxxx.                  <---- These would be the
               "fee_per_millionth": xxxxx.                      <---- newly added attributes 
            }
         ]
      }
   ]
}

[whitslack]

I believe this has been implemented (in 0.10.0 maybe?). The relevant members of each element of channels are fee_base_msat and fee_proportional_millionths.

[shinghim]

yep, those are already in there. Should this issue be closed then?

[jsarenik]

Yes, it seems like everything is in place already:

$ lightning-cli --version                                      
v0.10.1-2-g405b914
$ lightning-cli listpeers | grep fee_                          
               "last_tx_fee_msat": "4419000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,
               "last_tx_fee_msat": "4419000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,
               "last_tx_fee_msat": "4419000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,
               "last_tx_fee_msat": "4419000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,
               "last_tx_fee_msat": "491000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,
               "last_tx_fee_msat": "4934000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,
               "last_tx_fee_msat": "840000msat",
               "fee_base_msat": "0msat",
               "fee_proportional_millionths": 0,

[ecurrencyhodler]

We should probably close this issue.