connectd: check all chain hashs of the TLV array

darosior · darosior · commit af70d264e54d · 2019-12-25T00:34:59.000+01:00
diff --git a/connectd/peer_exchange_initmsg.c b/connectd/peer_exchange_initmsg.c
@@ -30,7 +30,7 @@ struct peer {
 static bool contains_common_chain(struct bitcoin_blkid *chains)
 {
 	for (size_t i = 0; i < tal_count(chains); i++) {
-		if (bitcoin_blkid_eq(&chains[0], &chainparams->genesis_blockhash))
+		if (bitcoin_blkid_eq(&chains[i], &chainparams->genesis_blockhash))
 			return true;
 	}
 	return false;

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ struct peer {`
`30`	`30`	`static bool contains_common_chain(struct bitcoin_blkid *chains)`
`31`	`31`	`{`
`32`	`32`	`for (size_t i = 0; i < tal_count(chains); i++) {`
`33`		`- if (bitcoin_blkid_eq(&chains[0], &chainparams->genesis_blockhash))`
	`33`	`+ if (bitcoin_blkid_eq(&chains[i], &chainparams->genesis_blockhash))`
`34`	`34`	`return true;`
`35`	`35`	`}`
`36`	`36`	`return false;`