Merge pull request #1239 from apoelstra/2023-05--fix-testmempoolaccept

jamesdorfman · web-flow · commit de942511a67c · 2023-05-05T03:02:40.000-04:00
testmempoolaccept: feed genesis hash into sighash computation
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -1172,7 +1172,7 @@ PackageMempoolAcceptResult MemPoolAccept::AcceptMultipleTransactions(const std::
     }
 
     for (Workspace& ws : workspaces) {
-        PrecomputedTransactionData txdata;
+        PrecomputedTransactionData txdata(args.m_chainparams.HashGenesisBlock());
         if (!PolicyScriptChecks(args, ws, txdata)) {
             // Exit early to avoid doing pointless work. Update the failed tx result; the rest are unfinished.
             package_state.Invalid(PackageValidationResult::PCKG_TX, "transaction failed");

Original file line number	Diff line number	Diff line change
`@@ -1172,7 +1172,7 @@ PackageMempoolAcceptResult MemPoolAccept::AcceptMultipleTransactions(const std::`
`1172`	`1172`	`}`
`1173`	`1173`
`1174`	`1174`	`for (Workspace& ws : workspaces) {`
`1175`		`- PrecomputedTransactionData txdata;`
	`1175`	`+ PrecomputedTransactionData txdata(args.m_chainparams.HashGenesisBlock());`
`1176`	`1176`	`if (!PolicyScriptChecks(args, ws, txdata)) {`
`1177`	`1177`	`// Exit early to avoid doing pointless work. Update the failed tx result; the rest are unfinished.`
`1178`	`1178`	`package_state.Invalid(PackageValidationResult::PCKG_TX, "transaction failed");`