Minor optimization to CLICKABLE_TEXT (it still needs performance improvements, reuse font, ...)

Delayed computation for JSON_FORMATTED_TEXT

Author: jocelyn

src/gui/clickable_text.e

@@ -207,20 +207,25 @@ feature {NONE} -- Properties
 
 	apply_custom_properties (a_style: STRING)
 		local
-			f: like current_format
+			f: detachable like current_format
 		do
-			f := new_format_from_current
-			if attached foreground_color (a_style) as fg then
-				f.set_color (fg)
-			end
-			if attached background_color (a_style) as bg then
-				f.set_background_color (bg)
-			end
-			if attached font (a_style) as ft then
-				f.set_font (ft)
+			if properties.has (a_style) then
+				f := new_format_from_current
+
+				if attached foreground_color (a_style) as fg then
+					f.set_color (fg)
+				end
+				if attached background_color (a_style) as bg then
+					f.set_background_color (bg)
+				end
+				if attached font (a_style) as ft then
+					f.set_font (ft)
+				end
 			end
 			record_properties (a_style)
-			widget.set_current_format (f)
+			if f /= Void then
+				widget.set_current_format (f)
+			end
 		end
 
 	apply_link_properties
@@ -338,6 +343,17 @@ feature -- Properties
 
 feature {NONE} -- Implementation
 
+	parent_window_of (w: detachable EV_WIDGET): detachable EV_WINDOW
+		do
+			if w /= Void then
+				if attached {like parent_window_of} w as win then
+					Result := win
+				else
+					Result := parent_window_of (w.parent)
+				end
+			end
+		end
+
 	properties: HASH_TABLE [TUPLE [foreground_color, background_color: detachable EV_COLOR; font: detachable EV_FONT], STRING]
 
 invariant

src/gui/json_formatted_text.e

@@ -34,7 +34,7 @@ feature {NONE} -- Initialization
 			ft.set_weight ({EV_FONT_CONSTANTS}.Weight_bold)
 			set_font ("name", ft)
 
-			set_foreground_color ("string", create {EV_COLOR}.make_with_8_bit_rgb (0, 90, 0))
+			set_foreground_color ("string", create {EV_COLOR}.make_with_8_bit_rgb (0, 0, 0))
 			create ft
 			ft.set_shape ({EV_FONT_CONSTANTS}.Shape_italic)
 			set_font ("string", ft)
@@ -45,20 +45,51 @@ feature -- Change
 	set_json (j: detachable JSON_VALUE)
 		do
 			wipe_out
+			json := j
 			if j /= Void then
+				widget.set_text ("Click to get formatted body ...")
+				widget.focus_in_actions.extend_kamikaze (agent set_text_from_json)
+			end
+		end
+
+	json: detachable JSON_VALUE
+
+	set_text_from_json
+		local
+			win: like parent_window_of
+			p: detachable like {EV_WINDOW}.pointer_style
+		do
+			wipe_out
+			if attached json as j then
+				win := parent_window_of (widget)
+				if win /= Void then
+					p := win.pointer_style
+					win.set_pointer_style (stock_pixmaps.busy_cursor)
+				end
 				j.accept (Current)
+				if win /= Void then
+					if p = Void then
+						p := stock_pixmaps.standard_cursor
+					end
+					win.set_pointer_style (p)
+				end
 			end
 		end
 
+	stock_pixmaps: EV_STOCK_PIXMAPS
+		once
+			create Result
+		end
+
 feature	-- Json
 
 	initialize_visitor
 			-- Create a new instance
 		do
 			create indentation.make_empty
-			indentation_step := "%T"
+			indentation_step := "  "
 
-			object_count_inlining := 1
+			object_count_inlining := 3
 			array_count_inlining := 1
 		end