Skip to content

Commit 462077f

Browse files
committed
update upload to file
devide storage json to counter/gauge values
1 parent 7eb6c7e commit 462077f

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

internal/server/handlers/handlers.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ func PrintStatsValues(rw http.ResponseWriter, request *http.Request, metricsMemo
116116
</html>`
117117
keyValuesHTML := ""
118118

119-
for metricKey, metric := range metricsMemoryRepo.ReadAll() {
120-
keyValuesHTML += fmt.Sprintf("<div><b>%v</b>: %v</div>", metricKey, metric.GetStringValue())
119+
for metricKey, _ := range metricsMemoryRepo.ReadAll() {
120+
keyValuesHTML += fmt.Sprintf("<div><b>%v</b>: %v</div>", metricKey, "metric.GetStringValue()")
121121
}
122122

123123
htmlPage := fmt.Sprintf(htmlTemplate, keyValuesHTML)
File renamed without changes.

internal/server/storage/metricsMemoryRepo.go

+4-10
Original file line numberDiff line numberDiff line change
@@ -188,17 +188,11 @@ func (metricsMemoryRepo MetricsMemoryRepo) InitStateValues(DBSchema map[string]M
188188
}
189189
}
190190

191-
func (metricsMemoryRepo MetricsMemoryRepo) ReadAll() map[string]MetricValue {
192-
allMetrics := make(map[string]MetricValue)
193-
194-
for metricKey, metricValue := range metricsMemoryRepo.gaugeStorage.GetSchemaDump() {
195-
allMetrics[metricKey] = metricValue
196-
}
197-
198-
for metricKey, metricValue := range metricsMemoryRepo.counterStorage.GetSchemaDump() {
199-
allMetrics[metricKey] = metricValue
191+
func (metricsMemoryRepo MetricsMemoryRepo) ReadAll() map[string]MetricMap {
192+
return map[string]MetricMap{
193+
"gauge": metricsMemoryRepo.gaugeStorage.GetSchemaDump(),
194+
"counter": metricsMemoryRepo.counterStorage.GetSchemaDump(),
200195
}
201-
return allMetrics
202196
}
203197

204198
func (metricsMemoryRepo MetricsMemoryRepo) Close() error {

internal/server/storage/storage.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package storage
22

3+
type MetricMap map[string]MetricValue
4+
35
type MetricStorager interface {
46
Update(key string, value MetricValue) error
57
Read(key string, metricType string) (MetricValue, error)
6-
ReadAll() map[string]MetricValue
8+
ReadAll() map[string]MetricMap
79
Close() error
810
}

0 commit comments

Comments
 (0)