Merge pull request #443 from protomors/dev

Alternative fixes to App.vue

Author: mariusa

src/App.vue

@@ -133,9 +133,9 @@
 
     <h5 class="mt-3">None</h5>
     <b-card>
-      <b-skeleton width="85%"></b-skeleton>
-      <b-skeleton width="55%"></b-skeleton>
-      <b-skeleton width="70%"></b-skeleton>
+      <b-skeleton animation width="85%"></b-skeleton>
+      <b-skeleton animation width="55%"></b-skeleton>
+      <b-skeleton animation width="70%"></b-skeleton>
     </b-card>
     <b-table-simple responsive>
       <b-thead>
@@ -2087,8 +2087,8 @@ export default defineComponent({
       )
     }
 
-    const tagValidator = (tag: string | undefined) =>
-      !!tag && tag === tag.toLowerCase() && tag.length > 2 && tag.length < 6
+    const tagValidator = (tag: string) =>
+      tag === tag.toLowerCase() && tag.length > 2 && tag.length < 6
 
     function onTagState(valid: string[], invalid: string[], duplicate: string[]) {
       // console.log({

src/components/BFormTags/BFormTags.vue

@@ -141,7 +141,7 @@ interface BFormTagsProps {
   tagPills?: boolean
   tagRemoveLabel?: string
   tagRemovedLabel?: string
-  tagValidator?: (t?: string) => boolean
+  tagValidator?: (t: string) => boolean
   tagVariant?: ColorVariant
 }
 

src/components/BSkeleton/BSkeleton.vue

@@ -23,8 +23,9 @@ const props = withDefaults(defineProps<BSkeletonProps>(), {
 
 const classes = computed(() => [
   `b-skeleton-${props.type}`,
-  `b-skeleton-animate-${props.animation}`,
   {
+    [`b-skeleton-animate-${props.animation}`]:
+      typeof props.animation === 'boolean' ? undefined : props.animation,
     [`bg-${props.variant}`]: props.variant,
   },
 ])

src/types/SkeletonAnimation.d.ts

@@ -1,3 +1,3 @@
-type SkeletonAnimation = 'wave' | 'fade' | 'throb'
+type SkeletonAnimation = boolean | 'wave' | 'fade' | 'throb'
 
 export default SkeletonAnimation

src/types/components/BFormTags/BFormTags.d.ts

@@ -30,7 +30,7 @@ export interface Props {
   tagPills?: boolean
   tagRemoveLabel?: string
   tagRemovedLabel?: string
-  tagValidator?: (t: unknown) => boolean
+  tagValidator?: (t: string) => boolean
   tagVariant?: ColorVariant
 }
 // Emits