Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and deal with test runs that the Sequel generates #4

Open
tbooth opened this issue Jan 30, 2023 · 3 comments
Open

Detect and deal with test runs that the Sequel generates #4

tbooth opened this issue Jan 30, 2023 · 3 comments

Comments

@tbooth
Copy link
Member

tbooth commented Jan 30, 2023

Test runs are synthetic runs where the system is run dry - there is no actual cell present. Test cells are pretty easy to spot from looking at the XML. But possibly the pipeline will see the run before it sees the cell info, so we can't always immediately see if a run is a "test run".

We can probably assume that all these runs will have a single cell, but I don't think I need to. Maybe just regard any run where all cells are test cells as a "test run" and close the ticket automatically when the final report is made. The interim e-mails will clearly say that the cell is a test cell.

Once we are producing a single report per cell then I think this logic will be a tad cleaner, so address that (#2) first.

@tbooth
Copy link
Member Author

tbooth commented Feb 27, 2023

Example of such a run - r64175e_20230220_093234

@tbooth
Copy link
Member Author

tbooth commented Jul 6, 2023

Added an is_testrun.sh script that currently looks for InstrumentId="Inst1234" in run.metadata.xml (but could easily grep for various other strings).

And a testrun state that is analogous to the aborted state.

TODO

  1. need to ensure that runs left in the testrun state are cleaned up by the data deletion scripts.
  2. need to ensure that reports on egcloud are cleaned up (both ones on there now, and also no more being added)

@tbooth
Copy link
Member Author

tbooth commented Jul 20, 2023

Reports are cleaned up, but I still need to fix and check the deletion scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant