Less deprecations

Author: PowerKiKi

bin/pre-commit.sh

@@ -0,0 +1,33 @@
+#!/bin/sh
+
+pass=true
+
+files=$(git diff --cached --name-only --diff-filter=ACMR | grep -E '\.(php|phtml)$')
+if [ "$files" != "" ]; then
+
+    # Run php syntax check before commit
+    for file in ${files}; do
+        php -l ${file}
+        if [ $? -ne 0 ]; then
+            pass=false
+        fi
+    done
+
+    # Run php-cs-fixer validation before commit
+    echo "$files" | xargs php ./vendor/bin/php-cs-fixer fix --diff --config .php-cs-fixer.dist.php
+    if [ $? -ne 0 ]; then
+        pass=false
+    fi
+
+    # Automatically add files that may have been fixed by php-cs-fixer
+    echo "$files" | xargs git add
+fi
+
+if $pass; then
+    exit 0
+else
+    echo ""
+    echo "PRE-COMMIT HOOK FAILED:"
+    echo "Code style validation failed. Please fix errors and try committing again."
+    exit 1
+fi

library/Zend/Controller/Router/Rewrite.php

@@ -485,7 +485,7 @@ public function assemble($userParams, $name = null, $reset = false, $encode = tr
         $url = $route->assemble($params, $reset, $encode);
 
         if (!preg_match('|^[a-z]+://|', $url)) {
-            $url = rtrim($this->getFrontController()->getBaseUrl(), self::URI_DELIMITER) . self::URI_DELIMITER . $url;
+            $url = rtrim($this->getFrontController()->getBaseUrl() ?? '', self::URI_DELIMITER) . self::URI_DELIMITER . $url;
         }
 
         return $url;

library/Zend/Controller/Router/Route.php

@@ -280,7 +280,7 @@ public function match($path, $partial = false)
                     }
                 }
 
-                if (substr($part, 0, 2) === '@@') {
+                if (substr($part ?? '', 0, 2) === '@@') {
                     $part = substr($part, 1);
                 }
 

library/Zend/Form.php

@@ -2282,6 +2282,7 @@ protected function _dissolveArrayUnsetKey($array, $arrayPath, $key)
      */
     protected function _attachToArray($value, $arrayPath)
     {
+        $arrayPath = (string) $arrayPath;
         // As long as we have more levels
         while ($arrayPos = strrpos($arrayPath, '[')) {
             // Get the next key in the path

library/Zend/View/Helper/BaseUrl.php

@@ -65,7 +65,7 @@ public function baseUrl($file = null)
      */
     public function setBaseUrl($base)
     {
-        $this->_baseUrl = rtrim($base, '/\\');
+        $this->_baseUrl = rtrim($base ?? '', '/\\');
 
         return $this;
     }
@@ -105,7 +105,7 @@ protected function _removeScriptName($url)
             return $url;
         }
 
-        if (($pos = strripos($url, basename($_SERVER['SCRIPT_NAME']))) !== false) {
+        if (($pos = strripos($url ?? '', basename($_SERVER['SCRIPT_NAME']))) !== false) {
             $url = substr($url, 0, $pos);
         }