-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipe_perfmetrics_land_CMIP5
fails in multi_model_statistics
step
#2594
Comments
it's always good to assign peeps, Manu, even if they won't send you Xmas cards anymore 😁 |
So apparently the longitude coordinates of some datasets differ. From the debug log it's not clear which one is causing the problem... I think multi-model stats is behaving as expected and the problem is with the data. I suppose this message could be more helpful though:
NB: this is the debug log |
The full message is one line above the error:
Since the datasets are regridded before calculating the multi-model statistics, I guess it's rather an issue in Unfortunately it's not trivial to find out which dataset is causing the problem, since the error message of |
I think a restricted run with only those datasets listed and only the preprocessor that is assigned to that task, and save intermediary cubes would do the trick, I can try it on JASMIN |
OK I reproduced the bugger with this: ---
documentation:
title: Performance metrics for essential climate variables in CMIP5
description: |
Recipe for plotting the performance metrics for the CMIP5 datasets,
including the standard ECVs as in Gleckler et al., and some additional
variables (like ozone, sea-ice, aerosol...)
authors:
- frank_franziska
- righi_mattia
- eyring_veronika
maintainer:
- righi_mattia
references:
- gleckler08jgr
projects:
- esmval
- embrace
preprocessors:
ppNOLEV:
regrid:
target_grid: 1x1
scheme: linear
mask_fillvalues:
threshold_fraction: 0.95
multi_model_statistics:
span: overlap
statistics: [mean, median]
diagnostics:
sm:
description: Soil moisture
themes:
- phys
realms:
- land
variables:
fgco2:
short_name: fgco2
preprocessor: ppNOLEV
mip: Omon
project: CMIP5
exp: historical
ensemble: r1i1p1
start_year: 1998
end_year: 1999
additional_datasets:
- {dataset: CanESM2}
- {dataset: CESM1-BGC}
- {dataset: CMCC-CESM}
- {dataset: CNRM-CM5}
- {dataset: GFDL-ESM2G}
- {dataset: GFDL-ESM2M}
- {dataset: GISS-E2-H-CC}
- {dataset: GISS-E2-R-CC}
- {dataset: HadGEM2-CC}
- {dataset: HadGEM2-ES}
- {dataset: inmcm4}
- {dataset: IPSL-CM5A-LR}
- {dataset: IPSL-CM5A-MR}
- {dataset: IPSL-CM5B-LR}
- {dataset: MIROC-ESM}
- {dataset: MIROC-ESM-CHEM}
- {dataset: MPI-ESM-LR}
- {dataset: MPI-ESM-MR}
- {dataset: MRI-ESM1}
- {dataset: NorESM1-ME}
scripts: null I am trying now to save the intermediary files, see which one is causing it, but I suspect I am going to run out of disk quota on JASMIN - if I do, at least you have a simplified small-scale recipe that can help find out which one is the party pooper |
OK found it! Bl**dy Russkies: the looks like this
and it lacks any lon or lat naming: printing its
-> time only! whereas all others are nicely T-X-Y:
why this is happening? Something is happening after step 6 of the preproc (add_fx_variables) namely in regrid, since before regrid the Russ cube looks like this:
whereas the others look like:
I am not a specialist of ocean/land data so I am not sure what the heck's up in here, but at least this can be a good clue for you or @zklaus to understand what's the hap. Incidentally, what's |
Re |
Haha, cheers, Klaus, my book's ye olde. Note that iris is complaining about
that too, so its book is ye olde too. Can you make any sense of the inmcm4
data tho?
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Mon, 14 Mar 2022, 17:56 Klaus Zimmermann, ***@***.***> wrote:
Re where sea, update your book:
http://cfconventions.org/Data/cf-conventions/cf-conventions-1.9/cf-conventions.html#statistics-applying-portions
—
Reply to this email directly, view it on GitHub
<#2594 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5EFI5B23UFFPYB4UEORI3U754VBANCNFSM5QQHEPYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
recipe_perfmetrics_land_CMIP5
fails in mulit_model_statistics
steprecipe_perfmetrics_land_CMIP5
fails in multi_model_statistics
step
Sorry I did not have time to check this for 2.6, I will remove it from the milestone |
I ran in to the same issue when testing a recipe for an IPCC figure #2983 (Fig. 3.23). Is there a plan to solve this for v2.8.0? |
well we could exclude all Russian models from our runs, but I got a feeling you guys in Germany would freeze this winter if we did that 🤣 Seriously now, @sloosvel you think you'd have some time look at this please, I think the clues are all in #2594 (comment) we just need a Benoit Blanc solve the case 😁 |
I currently don't have much time, sorry! |
It seems that we haven't found a volunteer to fix this recipe. If the issue is still affecting the recipe, this will be flagged as broken for v2.8. Let's hope the issue could be solved before we would need to consider retiring such recipe... |
An interesting outcome of the recipe testing with Core |
Here is the link to the final plot produced with the successful run that used Core |
Looks fine science wise, it was the prototype of the ipcc ar6 fig 3-42 and the comparable values look good to me! |
Thanks very much for checking @bettina-gier! |
That seems unlikely. From @valeriupredoi's analysis in #2594 (comment) it looks like the |
Describe the bug
recipe_perfmetrics_land_CMIP5
currently fails in themulit_model_statistics
step:Please attach
main_log_debug.txt
file, this can also be found in therun
directory in the output directory: https://esmvaltool.dkrz.de/shared/esmvaltool/v2.5.0-test-rc4/recipe_perfmetrics_land_CMIP5_20220303_185908/run/main_log_debug.txtThe text was updated successfully, but these errors were encountered: