You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The variable is in zm_conv_intr.F90 and it should retain the 0.5 value as default to make it bfb in CAM7
It will make it easier for everyone to carry out sensitivity experiments and add visibility to an important parameter.
Is there anyone in particular you want to be part of this conversation?
Nope. it's a pretty simple change.
Will this change (regression test) answers?
No
Will you be implementing this enhancement yourself?
Any CAM SE can do this
The text was updated successfully, but these errors were encountered:
… scheme (#214)
Originator(s): swrneale
Description (include issue title and the keyword ['closes', 'fixes',
'resolves'] and issue number):
From issue
[#203](#203) "Change
the 'parcel_hscale' parameter in the ZM convection (zm_conv_intr.F90) to
a namelist parameter"
This PR is needed in parallel with ESCOMP/cam PR#
[1266](ESCOMP/CAM#1266)
List all namelist files that were added or changed:
M schemes/zhang_mcfarlane/zm_conv_options_namelist.xml
- Added new 'zmconv_parcel_hscale' namelist parameter for ZM scheme
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
M schemes/zhang_mcfarlane/zm_conv_options.F90
M schemes/zhang_mcfarlane/zm_conv_options.meta
- Added new 'zmconv_parcel_hscale' namelist parameter for ZM scheme
M schemes/zhang_mcfarlane/zm_convr.F90
M schemes/zhang_mcfarlane/zm_convr.meta
- Replace hardcoded 'parcel_hscale' parameter with
'zmconv_parcel_hscale' namelist variable in core ZM scheme (zm_convr).
List all automated tests that failed, as well as an explanation for why
they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package,
algorithm change, tuning change, etc?
No
If yes to the above question, describe how this code was validated with
the new/modified features:
---------
Co-authored-by: Jesse Nusbaumer <[email protected]>
** Partner Issue to the ESCOMP/CAM one **
What is the feature/what would you like to discuss?
It's simple but I'd like to turn the hardwired parameter parcel_hscale Into a namelist parameter.
It's currently in the code here.
! Scaling of PBL height to give parcel mixing length for lparcel_pbl=True
real(kind_phys), parameter :: parcel_hscale = 0.5_kind_phys
The variable is in zm_conv_intr.F90 and it should retain the 0.5 value as default to make it bfb in CAM7
It will make it easier for everyone to carry out sensitivity experiments and add visibility to an important parameter.
Is there anyone in particular you want to be part of this conversation?
Nope. it's a pretty simple change.
Will this change (regression test) answers?
No
Will you be implementing this enhancement yourself?
Any CAM SE can do this
The text was updated successfully, but these errors were encountered: