Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-needed "il1g" variable from ZM schemes. #202

Open
nusbaume opened this issue Feb 12, 2025 · 1 comment
Open

Remove un-needed "il1g" variable from ZM schemes. #202

nusbaume opened this issue Feb 12, 2025 · 1 comment
Labels
cleanup This issue indicates an opportunity for code cleanup. good first issue Good for newcomers

Comments

@nusbaume
Copy link
Collaborator

Currently the zm_conv_convtran_run and zm_conv_momtran_run schemes have an "il1g" input variable which has a standard name of index_of_first_column_of_gathered_deep_convection_arrays.

However, in CAM and CAM-SIMA this variable appears to be hardcoded to one. Thus it would likely clean-up the code if this variable was removed from the relevant subroutine arguments and instead just made a local variable (or all of the relevant uses of the variable were simply replaced with 1).

Note that once this issue has been resolved the "il1g" variable can also be removed from the CAM-SIMA registry as well.

@nusbaume nusbaume added cleanup This issue indicates an opportunity for code cleanup. good first issue Good for newcomers labels Feb 12, 2025
@swrneale
Copy link
Contributor

In fact in some of the other convection routines there is no version of il1g passed at all and they just pass il2g (cldprp). I wonder what it would take to get rid of gathering altogether. I seem to remember @Katetc did this for microphysics a ways back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup This issue indicates an opportunity for code cleanup. good first issue Good for newcomers
Projects
Status: To Do
Development

No branches or pull requests

2 participants