Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing screenshot images with knitr::include_url #54

Open
cmorganl opened this issue Feb 28, 2022 · 0 comments
Open

Consider replacing screenshot images with knitr::include_url #54

cmorganl opened this issue Feb 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cmorganl
Copy link
Collaborator

Rather than having to potentially update multiple screenshots for this project, we could use the function include_url from the knitr package. Example usage is below:

knitr::include_url("https://www.uniprot.org/uniprot/?query=%22particulate+methane+monooxygenase%22&sort=score", height = "400px")

A couple of issues exist:

  • knitr::include_url is still being developed and I've seen many issues caused by this function. Patches are in the development branch on the knitr repository but not on CRAN. So at the very least, we will need to wait until the functionality is stable.
  • Intermittent server outages that coincide with bookdown builds would result in empty images

I thought it would be an interesting enhancement so I just wanted to log it for the future. Nothing needs to be changed immediately.

@cmorganl cmorganl added the enhancement New feature or request label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant