Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a way to package for the current system #1252

Open
TomaSajt opened this issue Aug 30, 2024 · 0 comments
Open

Consider adding a way to package for the current system #1252

TomaSajt opened this issue Aug 30, 2024 · 0 comments

Comments

@TomaSajt
Copy link

TomaSajt commented Aug 30, 2024

This would be useful for people who want to build the app for their own system without having to worry about specifying the correct build task name.
Also, since linux+arm is not yet officially supported this would allow them to build the app without having to modify the mk script.

This could be achieved by conditionally setting the platform and arch arguments passed into electron-packager. Sadly, just using undefined or null didn't seem to work, so the solution might not be very pretty :/

Also, the 3rd party license copying logic might need to be updated too.
The .then() actually receives the output paths so you could use paths[0] for getting the directory instead of using _/${pj.name}/${pj.productName}-${x}-${y}

@TomaSajt TomaSajt changed the title Consider adding a way to packaging for the current system Consider adding a way to package for the current system Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants