Skip to content

Commit 5bbc07d

Browse files
committed
drop header inside Header, and set it in PageLayout
1 parent c777466 commit 5bbc07d

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/Header/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface HeaderProps {
1010

1111
const Header: FC<HeaderProps> = ({ logo, elements = [] }) => {
1212
return (
13-
<header className="header" role="banner">
13+
<div className="header">
1414
<div className="header__container">
1515
{!!logo && <div className="header__logo">{logo}</div>}
1616

@@ -22,7 +22,7 @@ const Header: FC<HeaderProps> = ({ logo, elements = [] }) => {
2222
</div>
2323
)}
2424
</div>
25-
</header>
25+
</div>
2626
);
2727
};
2828

src/PageLayout/PageLayout.stories.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,15 @@ export const FleshedOut: Story = {
5353
<Navigation
5454
key="nav"
5555
elements={[
56+
<a key="docs" href="#">
57+
Docs
58+
</a>,
59+
<a key="flakes" href="#">
60+
Flakes
61+
</a>,
62+
<a key="orgs" href="#">
63+
Orgs
64+
</a>,
5665
<Placeholder key="lorem" height="100%" label="Lorem" />,
5766
<Placeholder key="ipsum" height="100%" label="Ipsum" />,
5867
]}

0 commit comments

Comments
 (0)