Fix a case of static initialization order debacle

When descent3 is built with g++ -flto=auto, there is a crash at startup:

```
Program received signal SIGSEGV, Segmentation fault.
0x00005555557b3b20 in pilot::initialize (
    this=this@entry=0x555555fbd480 <Current_pilot>)
    at Descent3/pilot_class.cpp:208
208       game_window_w = Video_res_list[Current_video_resolution_id].width;
Missing separate debuginfos, use: zypper install libcpp-httplib0_20-debuginfo-0.20.1-2.1.x86_64 libSDL3-0-debuginfo-3.2.16-1.1.x86_64 libzstd1-x86-64-v3-debuginfo-1.5.7-3.1.x86_64
(gdb) p Current_video_resolution_id
$1 = 0
(gdb) p Video_res_list
$2 = std::vector of length 0, capacity 0

(gdb) bt
f0  pilot::initialize (this=this@entry=0x555555fbd480 <Current_pilot>) at Descent3/pilot_class.cpp:208
f1  pilot::pilot (this=<optimized out>, this=<optimized out>) at Descent3/pilot_class.cpp:177
f2  _sub_I_65535_0.0 ()
f3  call_init (argc=1, argv=0x7fffffffdb68, env=<optimized out>) at ../csu/libc-start.c:145
f4  __libc_start_main_impl
f5  _start () at ../sysdeps/x86_64/start.S:115
```

When ASAN/UBSAN is enabled in conjunction with LTO:

```
/usr/include/c++/14/bits/stl_vector.h:1144:34: runtime error: reference binding to null pointer of type 'struct value_type'
Descent3/pilot_class.cpp:208:63: runtime error: member access within null pointer of type 'struct value_type'
AddressSanitizer:DEADLYSIGNAL
=================================================================
==58724==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000
==58724==The signal is caused by a READ memory access.
==58724==Hint: address points to the zero page.
    f0 pilot::initialize() Descent3/pilot_class.cpp:208
    f1 pilot::pilot() Descent3/pilot_class.cpp:177
    f2 _sub_I_65535_0.0 (b/build/Descent3+0x52ece3)
    f3 call_init ../csu/libc-start.c:145
    f4 __libc_start_main_impl ../csu/libc-start.c:347
    f5 _start ../sysdeps/x86_64/start.S:115
```

``_sub_I_65535_0.0`` is indicative of a global constructor, so we
are looking at a case of Static Initialization Order Fiasco whereby
``pilot::initialize`` runs before ``Video_res_list`` gets initialized.

Static variables declared in functions are initialized on first use,
which can help steer global initialization short of placing the
global state in a class instance of its own.

Fixes: 40c7f0d

Author: jengelh

Descent3/config.cpp

@@ -314,31 +314,23 @@
 
 #define STAT_SCORE STAT_TIMER
 
-// This list is only used if `ConfigureDisplayResolutions` fails
-std::vector<tVideoResolution> Video_res_list = {{512, 384},
-                                                {640, 480},
-                                                {800, 600},
-                                                {960, 720},
-                                                {1024, 768},
-                                                {1280, 960},
-                                                {1600, 1200},
-                                                // 16:9
-                                                {1280, 720},
-                                                {1366, 768},
-                                                {1368, 768},
-                                                {1680, 1050},
-                                                {1920, 1080},
-                                                {2560, 1440},
-                                                {3840, 2160},
-                                                // 16:10
-                                                {1280, 800},
-                                                {1920, 1200},
-                                                {2560, 1600},
-                                                // Ultrawide
-                                                {2560, 1080},
-                                                {2880, 1200},
-                                                {3440, 1440},
-                                                {3840, 1600}};
+std::vector<tVideoResolution> &Video_res_list()
+{
+	// This list is only used if `ConfigureDisplayResolutions` fails
+	static std::vector<tVideoResolution> list = {
+		// 4:3
+		{512, 384}, {640, 480}, {800, 600}, {960, 720}, {1024, 768},
+		{1280, 960}, {1600, 1200},
+		// 16:9
+		{1280, 720}, {1366, 768}, {1368, 768}, {1680, 1050},
+		{1920, 1080}, {2560, 1440}, {3840, 2160},
+		// 16:10
+		{1280, 800}, {1920, 1200}, {2560, 1600},
+		// Ultrawide
+		{2560, 1080}, {2880, 1200}, {3440, 1440}, {3840, 1600}
+	};
+	return list;
+}
 
 int Default_resolution_id = 7; // 1280x720 in the default list
 int Current_video_resolution_id = Default_resolution_id;
@@ -417,15 +409,16 @@ void ConfigureDisplayResolutions() {
   if (resolutions_vec.empty()) {
     return;
   }
-  Video_res_list = std::move(resolutions_vec);
+  auto &vres = Video_res_list();
+  vres = std::move(resolutions_vec);
   SDL_free(displays);
 
   // Find the index of the current screen resolution in the list
-  auto current_res_id = std::find(Video_res_list.begin(), Video_res_list.end(), current_resolution);
-  if (current_res_id != Video_res_list.end()) {
-    Default_resolution_id = static_cast<int>(current_res_id - Video_res_list.begin());
+  auto current_res_id = std::find(vres.cbegin(), vres.cend(), current_resolution);
+  if (current_res_id != vres.end()) {
+    Default_resolution_id = static_cast<int>(current_res_id - vres.begin());
   } else {
-    Default_resolution_id = Video_res_list.size() - 1; // default to the highest supported resolution
+    Default_resolution_id = vres.size() - 1; // default to the highest supported resolution
   }
 
   int tmp;
@@ -434,8 +427,8 @@ void ConfigureDisplayResolutions() {
     Current_video_resolution_id = Default_resolution_id;
   }
 
-  LOG_DEBUG << "Resolution configured to w=" << Video_res_list[Current_video_resolution_id].width
-            << "h=" << Video_res_list[Current_video_resolution_id].height << " (id " << Current_video_resolution_id
+  LOG_DEBUG << "Resolution configured to w=" << vres[Current_video_resolution_id].width
+            << "h=" << vres[Current_video_resolution_id].height << " (id " << Current_video_resolution_id
             << ")";
 }
 
@@ -782,7 +775,8 @@ struct video_menu {
 
     // video resolution
     sheet->NewGroup(TXT_RESOLUTION, 0, 0);
-    std::string res = Video_res_list[Current_video_resolution_id].getName();
+    auto &vres = Video_res_list();
+    std::string res = vres[Current_video_resolution_id].getName();
     auto alloc_size = std::max(res.size() + 1, static_cast<size_t>(15));
     resolution_string = sheet->AddChangeableText(alloc_size);
     snprintf(resolution_string, alloc_size, res.c_str());
@@ -856,8 +850,9 @@ struct video_menu {
       Render_preferred_state.bit_depth = Render_preferred_bitdepth;
       rend_SetPreferredState(&Render_preferred_state, true);
 
-      int temp_w = Video_res_list[Current_video_resolution_id].width;
-      int temp_h = Video_res_list[Current_video_resolution_id].height;
+      auto &vres = Video_res_list();
+      int temp_w = vres[Current_video_resolution_id].width;
+      int temp_h = vres[Current_video_resolution_id].height;
       Current_pilot.set_hud_data(NULL, NULL, NULL, &temp_w, &temp_h);
     }
 
@@ -886,7 +881,8 @@ struct video_menu {
       select_sheet->AddButton(TXT_OK, UID_OK);
       select_sheet->AddButton(TXT_CANCEL, UID_CANCEL);
 
-      for (auto &resolution : Video_res_list) {
+      auto &vres = Video_res_list();
+      for (auto &resolution : vres) {
         resolution_list->AddItem(resolution.getName().c_str());
       }
 
@@ -901,10 +897,10 @@ struct video_menu {
 
       if (res == UID_OK) {
         int newindex = resolution_list->GetCurrentIndex();
-        if (static_cast<size_t>(newindex) < Video_res_list.size() && Current_video_resolution_id != newindex) {
+        if (static_cast<size_t>(newindex) < vres.size() && Current_video_resolution_id != newindex) {
           resolution_changed = true;
           Current_video_resolution_id = newindex;
-          std::string res = Video_res_list[Current_video_resolution_id].getName();
+          std::string res = vres[Current_video_resolution_id].getName();
           snprintf(resolution_string, res.size() + 1, res.c_str());
         }
       }

Descent3/config.h

@@ -155,7 +155,7 @@ struct tVideoResolution
   }
 };
 
-extern std::vector<tVideoResolution> Video_res_list;
+extern std::vector<tVideoResolution> &Video_res_list();
 extern int Default_resolution_id;
 extern int Current_video_resolution_id;
 extern int Display_id;

Descent3/game.cpp

@@ -937,8 +937,8 @@ void SetScreenMode(int sm, bool force_res_change) {
     int scr_width, scr_height, scr_bitdepth;
 
     if (sm == SM_GAME) {
-      scr_width = Video_res_list[Current_video_resolution_id].width;
-      scr_height = Video_res_list[Current_video_resolution_id].height;
+      scr_width = Video_res_list()[Current_video_resolution_id].width;
+      scr_height = Video_res_list()[Current_video_resolution_id].height;
       scr_bitdepth = Render_preferred_bitdepth;
     } else {
       scr_width = FIXED_SCREEN_WIDTH;

Descent3/init.cpp

@@ -1305,7 +1305,7 @@ void LoadGameSettings() {
   Database->read("Specmapping", &Detail_settings.Specular_lighting);
   Database->read("RS_bitdepth", &Render_preferred_bitdepth, sizeof(Render_preferred_bitdepth));
   Database->read_int("RS_resolution", &tempint);
-  if (tempint >= 0 && tempint < std::size(Video_res_list))
+  if (tempint >= 0 && tempint < Video_res_list().size())
     Current_video_resolution_id = tempint;
   else
     LOG_WARNING << "Game settings contain a display resolution index that is out of bounds. Starting with default resolution.";

Descent3/pilot_class.cpp

@@ -205,8 +205,15 @@ void pilot::initialize(void) {
   hud_mode = (uint8_t)HUD_COCKPIT;
   hud_stat = 0;
   hud_graphical_stat = STAT_STANDARD;
-  game_window_w = Video_res_list[Current_video_resolution_id].width;
-  game_window_h = Video_res_list[Current_video_resolution_id].height;
+  auto &vres = Video_res_list();
+  if (Current_video_resolution_id >= 0 &&
+      static_cast<size_t>(Current_video_resolution_id) < vres.size()) {
+		game_window_w = vres[Current_video_resolution_id].width;
+		game_window_h = vres[Current_video_resolution_id].height;
+  } else {
+		game_window_w = 0;
+		game_window_h = 0;
+  }
   num_missions_flown = 0;
   mission_data = NULL;
   mouselook_control = false;

renderer/HardwareOpenGL.cpp

@@ -348,8 +348,9 @@ void opengl_SetDefaults() {
 extern renderer_preferred_state Render_preferred_state;
 
 int opengl_Setup(oeApplication *app, const int *width, const int *height) {
-  int winw = Video_res_list[Current_video_resolution_id].width;
-  int winh = Video_res_list[Current_video_resolution_id].height;
+  auto &vres = Video_res_list();
+  int winw = vres[Current_video_resolution_id].width;
+  int winh = vres[Current_video_resolution_id].height;
 
   SDL_ClearError();
   if (!SDL_WasInit(SDL_INIT_VIDEO)) {