Skip to content

Commit 0ce2f49

Browse files
Remove the build warning below and redundant spaces since r263985.
warning: redundant move in return statement [-Wredundant-move] No new tests, no new behaviors. * Modules/webaudio/AudioNode.h: * Modules/webaudio/PannerNode.cpp: (WebCore::PannerNode::create): (WebCore::PannerNode::PannerNode): * Modules/webaudio/PannerNode.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@264508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 5a98f15 commit 0ce2f49

File tree

4 files changed

+28
-15
lines changed

4 files changed

+28
-15
lines changed

Source/WebCore/ChangeLog

+13
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2020-07-17 Joonghun Park <[email protected]>
2+
3+
Remove the build warning below and redundant spaces since r263985.
4+
warning: redundant move in return statement [-Wredundant-move]
5+
6+
No new tests, no new behaviors.
7+
8+
* Modules/webaudio/AudioNode.h:
9+
* Modules/webaudio/PannerNode.cpp:
10+
(WebCore::PannerNode::create):
11+
(WebCore::PannerNode::PannerNode):
12+
* Modules/webaudio/PannerNode.h:
13+
114
2020-07-16 Rob Buis <[email protected]>
215

316
Make DocumentParser.ParserState an enum class

Source/WebCore/Modules/webaudio/AudioNode.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,10 @@ class AudioNode
210210
volatile bool m_isInitialized { false };
211211
NodeType m_nodeType { NodeTypeUnknown };
212212
Ref<BaseAudioContext> m_context;
213-
213+
214214
// FIXME: Remove m_sampleRate once old constructor is removed.
215215
float m_sampleRate;
216-
216+
217217
Vector<std::unique_ptr<AudioNodeInput>> m_inputs;
218218
Vector<std::unique_ptr<AudioNodeOutput>> m_outputs;
219219

Source/WebCore/Modules/webaudio/PannerNode.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -97,32 +97,32 @@ ExceptionOr<Ref<PannerNode>> PannerNode::create(BaseAudioContext& context, const
9797
auto result = panner->setMaxDistance(options.maxDistance);
9898
if (result.hasException())
9999
return result.releaseException();
100-
100+
101101
result = panner->setRefDistance(options.refDistance);
102102
if (result.hasException())
103103
return result.releaseException();
104-
104+
105105
result = panner->setRolloffFactor(options.rolloffFactor);
106106
if (result.hasException())
107107
return result.releaseException();
108-
108+
109109
result = panner->setConeOuterGain(options.coneOuterGain);
110110
if (result.hasException())
111111
return result.releaseException();
112-
112+
113113
result = panner->setChannelCount(options.channelCount.valueOr(2));
114114
if (result.hasException())
115115
return result.releaseException();
116-
116+
117117
result = panner->setChannelCountMode(options.channelCountMode.valueOr(ChannelCountMode::ClampedMax));
118118
if (result.hasException())
119119
return result.releaseException();
120-
120+
121121
result = panner->setChannelInterpretation(options.channelInterpretation.valueOr(ChannelInterpretation::Speakers));
122122
if (result.hasException())
123123
return result.releaseException();
124-
125-
return WTFMove(panner);
124+
125+
return panner;
126126
}
127127

128128
PannerNode::PannerNode(BaseAudioContext& context, const PannerOptions& options)
@@ -143,10 +143,10 @@ PannerNode::PannerNode(BaseAudioContext& context, const PannerOptions& options)
143143
setConeInnerAngle(options.coneInnerAngle);
144144
setConeOuterAngle(options.coneOuterAngle);
145145
setNodeType(NodeTypePanner);
146-
146+
147147
addInput(makeUnique<AudioNodeInput>(this));
148148
addOutput(makeUnique<AudioNodeOutput>(this, 2));
149-
149+
150150
initialize();
151151
}
152152

Source/WebCore/Modules/webaudio/PannerNode.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class PannerNodeBase : public AudioNode {
5151
virtual float dopplerRate() = 0;
5252

5353
protected:
54-
54+
5555
// FIXME: Remove once dependencies on old constructor are removed
5656
PannerNodeBase(BaseAudioContext&, float sampleRate);
5757
PannerNodeBase(BaseAudioContext&);
@@ -72,9 +72,9 @@ class PannerNode final : public PannerNodeBase {
7272
{
7373
return adoptRef(*new PannerNode(context, sampleRate));
7474
}
75-
75+
7676
static ExceptionOr<Ref<PannerNode>> create(BaseAudioContext&, const PannerOptions& = { });
77-
77+
7878
virtual ~PannerNode();
7979

8080
// AudioNode

0 commit comments

Comments
 (0)