Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Heap code #1048

Open
PeterBreen opened this issue Oct 2, 2023 · 3 comments
Open

Remove Heap code #1048

PeterBreen opened this issue Oct 2, 2023 · 3 comments
Labels
Full Stack Both front- and back-end work required

Comments

@PeterBreen
Copy link
Collaborator

PeterBreen commented Oct 2, 2023

DemocracyLab used to use Heap for analytics, but no longer - so all Heap-related code should be removed.

  • remove all instances/uses of of HEAP_ANALYTICS_ID
  • remove heapApi.js from 'common/components/utils'

We are likely to refactor our metrics utility for GA4, so please do not delete or remove the metrics.js / associated logging functions.

Then, smoke test the site to make sure render isn't blocked by the removal of heap.

Note for code reviewer: After this code is deployed,

@PeterBreen PeterBreen added Front End Primarily front-end (react/javascript) Full Stack Both front- and back-end work required under review Issue is under review, should not be assigned and removed under review Issue is under review, should not be assigned Front End Primarily front-end (react/javascript) labels Oct 2, 2023
@sp6370
Copy link
Collaborator

sp6370 commented Oct 13, 2023

Hi @PeterBreen!
Can I pick this up?

@PeterBreen
Copy link
Collaborator Author

Yes, please! I've assigned you. Feel free to reach out on github or slack if you've got any questions.

@sp6370
Copy link
Collaborator

sp6370 commented Nov 24, 2023

@PeterBreen Apologies for the delay. I have opened a new pull request,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Stack Both front- and back-end work required
Projects
Status: Needs review
2 participants