add custom PersonIdentifier field and widget

Author: awdem

Diff for: ynr/apps/bulk_adding/fields.py

@@ -0,0 +1,56 @@
+from django import forms
+from people.models import PersonIdentifier
+
+
+class PersonIdentifierWidget(forms.MultiWidget):
+    template_name = "bulk_add/includes/person_identifier_multiwidget.html"
+
+    def __init__(self, *args, **kwargs):
+        super().__init__(
+            widgets=[
+                forms.TextInput(),
+                forms.Select(
+                    choices=[("", "Select an option")]
+                    + PersonIdentifier.objects.select_choices()[1:],
+                ),
+            ],
+            **kwargs,
+        )
+
+    def decompress(self, value):
+        # TODO: Turn single value back into list of two values
+        return [None, None]
+
+
+class PersonIdentifierField(forms.MultiValueField):
+    def __init__(self, **kwargs):
+        fields = (
+            forms.CharField(
+                required=True,
+                error_messages={
+                    "incomplete": "Please enter a social media link",
+                },
+            ),
+            forms.ChoiceField(
+                required=True,
+                error_messages={
+                    "incomplete": "Please select a link type",
+                },
+                choices=[("", "Select an option")]
+                + PersonIdentifier.objects.select_choices()[1:],
+            ),
+        )
+        widget = PersonIdentifierWidget()
+
+        super().__init__(
+            fields=fields,
+            require_all_fields=False,
+            widget=widget,
+            **kwargs,
+        )
+
+    def compress(self, data_list):
+        # TODO:
+        # Validations
+        # if valid, create single value
+        return " ".join(data_list)

Diff for: ynr/apps/bulk_adding/forms.py

@@ -1,3 +1,4 @@
+from bulk_adding.fields import PersonIdentifierField
 from django import forms
 from django.core.exceptions import ValidationError
 from django.db.models import Prefetch
@@ -262,6 +263,10 @@ class BulkAddByPartyForm(NameOnlyPersonForm):
         required=False,
         widget=forms.NumberInput,
     )
+    person_identifier = PersonIdentifierField(
+        label="Links and social media",
+        required=False,
+    )
 
 
 class QuickAddSinglePersonForm(PopulatePartiesMixin, NameOnlyPersonForm):

Diff for: ynr/apps/bulk_adding/templates/bulk_add/includes/person_identifier_multiwidget.html

@@ -0,0 +1,16 @@
+<tr>
+    <td>
+        <div class="large-12 columns">
+        <div class="row collapse">
+            <div class="small-9 columns">
+                {% include widget.subwidgets.0.template_name with widget=widget.subwidgets.0 %}
+            </div>
+            <div class="small-3 columns">
+            <span class="postfix">
+                {% include widget.subwidgets.1.template_name with widget=widget.subwidgets.1 %}
+            </span>
+            </div>
+        </div>
+        </div>
+    </td>
+</tr>    

Diff for: ynr/apps/bulk_adding/tests/test_bulk_add_by_party.py

@@ -170,3 +170,35 @@ def test_submit_name_and_demographic_details_for_area(self):
         # We should have created 2 logged actions, one for person-create
         # and one for person-update (adding the membership)
         self.assertEqual(LoggedAction.objects.count(), 2)
+
+    def test_submit_social_media_link_without_link_type(self):
+        ballot = self.election.ballot_set.first()
+        form = self.app.get(
+            "/bulk_adding/party/parl.2015-05-07/PP52/",
+            user=self.user_who_can_upload_documents,
+        ).forms[1]
+
+        form["source"] = "https://example.com/candidates/"
+
+        # Fill in the link field but don't select the link type
+        form[f"{ballot.pk}-0-name"] = "Pemphero Pasternak"
+        form[f"{ballot.pk}-0-person_identifier_0"] = "https://example.com"
+
+        response = form.submit()
+        self.assertContains(response, "Please select a link type")
+
+    def test_submit_social_media_link_type_without_link(self):
+        ballot = self.election.ballot_set.first()
+        form = self.app.get(
+            "/bulk_adding/party/parl.2015-05-07/PP52/",
+            user=self.user_who_can_upload_documents,
+        ).forms[1]
+
+        form["source"] = "https://example.com/candidates/"
+
+        # Select a link type but leave link field blank
+        form[f"{ballot.pk}-0-name"] = "Pemphero Pasternak"
+        form[f"{ballot.pk}-0-person_identifier_1"] = "mastodon_username"
+
+        response = form.submit()
+        self.assertContains(response, "Please enter a social media link")