Do not report non-generic RecursiveIterator usage without bleeding edge

Author: ondrejmirtes

conf/bleedingEdge.neon

@@ -15,3 +15,4 @@ parameters:
 		wrongVarUsage: true
 		arrayDestructuring: true
 		objectFromNewClass: true
+		skipCheckGenericClasses: []

conf/config.neon

@@ -28,6 +28,8 @@ parameters:
 		wrongVarUsage: false
 		arrayDestructuring: false
 		objectFromNewClass: false
+		skipCheckGenericClasses:
+			- RecursiveIterator
 	fileExtensions:
 		- php
 	checkAlwaysTrueCheckTypeFunctionCall: false
@@ -182,7 +184,8 @@ parametersSchema:
 		checkMissingTemplateTypeInParameter: bool(),
 		wrongVarUsage: bool(),
 		arrayDestructuring: bool(),
-		objectFromNewClass: bool()
+		objectFromNewClass: bool(),
+		skipCheckGenericClasses: listOf(string())
 	])
 	fileExtensions: listOf(string())
 	checkAlwaysTrueCheckTypeFunctionCall: bool()
@@ -725,6 +728,7 @@ services:
 		class: PHPStan\Rules\Generics\GenericAncestorsCheck
 		arguments:
 			checkGenericClassInNonGenericObjectType: %checkGenericClassInNonGenericObjectType%
+			skipCheckGenericClasses: %featureToggles.skipCheckGenericClasses%
 
 	-
 		class: PHPStan\Rules\Generics\GenericObjectTypeCheck

src/Rules/Generics/GenericAncestorsCheck.php

@@ -21,17 +21,25 @@ class GenericAncestorsCheck
 
 	private bool $checkGenericClassInNonGenericObjectType;
 
+	/** @var string[] */
+	private array $skipCheckGenericClasses;
+
+	/**
+	 * @param string[] $skipCheckGenericClasses
+	 */
 	public function __construct(
 		ReflectionProvider $reflectionProvider,
 		GenericObjectTypeCheck $genericObjectTypeCheck,
 		VarianceCheck $varianceCheck,
-		bool $checkGenericClassInNonGenericObjectType
+		bool $checkGenericClassInNonGenericObjectType,
+		array $skipCheckGenericClasses = []
 	)
 	{
 		$this->reflectionProvider = $reflectionProvider;
 		$this->genericObjectTypeCheck = $genericObjectTypeCheck;
 		$this->varianceCheck = $varianceCheck;
 		$this->checkGenericClassInNonGenericObjectType = $checkGenericClassInNonGenericObjectType;
+		$this->skipCheckGenericClasses = $skipCheckGenericClasses;
 	}
 
 	/**
@@ -114,6 +122,9 @@ public function check(
 				}
 
 				$unusedNameClassReflection = $this->reflectionProvider->getClass($unusedName);
+				if (in_array($unusedNameClassReflection->getName(), $this->skipCheckGenericClasses, true)) {
+					continue;
+				}
 				if (!$unusedNameClassReflection->isGeneric()) {
 					continue;
 				}