Skip to content

Commit 799dca4

Browse files
committed
Remove unnecessary print statement leading to test failures
Closes #53
1 parent 9e6c1ef commit 799dca4

File tree

3 files changed

+76
-1
lines changed

3 files changed

+76
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515

1616
### Fixed
1717

18+
* Remove unnecessary `print` statement leading to test failures
19+
1820
## [0.6.1]
1921

2022
**Full Changelog**: <https://github.com/DeepLcom/sql-mock/compare/v0.6.0...v0.6.1>

src/sql_mock/helpers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ def replace_original_table_references(
7878
query_ast = _replace_table_ref_in_columns(
7979
query_ast=query_ast, table_ref=table_ref, new_ref=sql_mock_cte_name, dialect=dialect
8080
)
81-
print(query_ast.sql(pretty=True))
8281
return replace_tables(expression=query_ast, mapping={table_ref: sql_mock_cte_name}, dialect=dialect)
8382

8483

tests/sql_mock/clickhouse/test_query_execution.py

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
from datetime import datetime
23

34
import pytest
45

@@ -55,3 +56,76 @@ class ResultMock(ClickHouseTableMock):
5556
]
5657

5758
result.assert_equal(expected)
59+
60+
61+
def test_argmaxif():
62+
query = """SELECT
63+
user_id,
64+
count() AS num_sessions,
65+
countIf(valid = 1) AS num_valid_sessions,
66+
argMaxIf(in_trial, dt, isNotNull(in_trial)) AS in_trial
67+
FROM sessions
68+
GROUP BY user_id
69+
"""
70+
71+
@table_meta(table_ref="sessions")
72+
class SessionsMock(ClickHouseTableMock):
73+
dt = col.Datetime(default=datetime(2024, 1, 1, 10, 30))
74+
valid = col.Boolean(default=True)
75+
user_id = col.String(default="foo")
76+
in_trial = col.Int(default=0, nullable=True)
77+
78+
@table_meta(query=query)
79+
class ResultMock(ClickHouseTableMock):
80+
user_id = col.String(default="foo")
81+
num_sessions = col.Int(default=0)
82+
num_valid_sessions = col.Int(default=0)
83+
in_trial = col.Int(default=0)
84+
85+
sessions_mock = SessionsMock.from_dicts(
86+
[
87+
dict(
88+
dt=datetime(2024, 1, 1, 10),
89+
valid=1,
90+
user_id="foo",
91+
in_trial=1,
92+
),
93+
dict(
94+
dt=datetime(2024, 1, 2, 10),
95+
valid=0,
96+
user_id="foo",
97+
in_trial=1,
98+
),
99+
dict(
100+
dt=datetime(2024, 1, 3, 10),
101+
valid=1,
102+
user_id="foo",
103+
in_trial=1,
104+
),
105+
dict(
106+
dt=datetime(2024, 1, 4, 10),
107+
valid=1,
108+
user_id="foo",
109+
in_trial=None,
110+
),
111+
dict(
112+
dt=datetime(2024, 1, 5, 10),
113+
valid=1,
114+
user_id="foo",
115+
in_trial=0,
116+
),
117+
]
118+
)
119+
120+
result = ResultMock.from_mocks(input_data=[sessions_mock])
121+
122+
expected = [
123+
dict(
124+
user_id="foo",
125+
num_sessions=5,
126+
num_valid_sessions=4,
127+
in_trial=0,
128+
)
129+
]
130+
131+
result.assert_equal(expected)

0 commit comments

Comments
 (0)