Galaxy score improvement (#235)

* [702] Use 'galaxy_tags' rather than 'categories'

* [702] Tags must contain lowercase letters and digits only, invalid: 'database:nosql'

* [201] Trailing whitespace

* [303] systemctl used in place of systemd module

* Suppress ansible_lint warning [403] Package installs should not use latest.

Conditionally install the i686 build of libgcc if we are building 32-bit
It must be version-locked with x64 libgcc, so use 'latest' to update libgcc first
Otherwise you get a version mismatch error from yum when installing.

Author: bbaassssiiee

meta/main.yml

@@ -18,8 +18,8 @@ galaxy_info:
       versions:
         - 11
         - 12
-  categories:
+  galaxy_tags:
     - database
-    - database:nosql
+    - nosql
 
 dependencies: []

tasks/dependencies.yml

@@ -28,6 +28,8 @@
     name: libgcc
     state: latest
   when: ansible_os_family == "RedHat" and redis_make_32bit|bool
+  tags:
+    - skip_ansible_lint
 
 - name: install redhat 32-bit dependencies
   yum:
@@ -36,6 +38,8 @@
       - glibc-devel.i686
     state: latest
   when: ansible_os_family == "RedHat" and redis_make_32bit|bool
+  tags:
+    - skip_ansible_lint
 
 - name: install suse dependencies
   zypper:
@@ -44,6 +48,6 @@
       - make
       # These should be `else omit`, but that doesn't quite work, so duplicate gcc
       - "{{ 'gcc-32bit' if redis_make_32bit|bool else 'gcc' }}"
-      - "{{ 'libgcc_s1-32bit' if redis_make_32bit|bool else 'gcc' }}"      
+      - "{{ 'libgcc_s1-32bit' if redis_make_32bit|bool else 'gcc' }}"
     state: present
   when: ansible_os_family == 'Suse'

tasks/sentinel.yml

@@ -46,7 +46,8 @@
     - (redis_sentinel_pidfile|dirname).startswith("/var/run") or (redis_sentinel_pidfile|dirname).startswith("/run")
 
 - name: reload systemd daemon
-  command: systemctl daemon-reload
+  systemd:
+    daemon_reload: true
   when:
     - redis_as_service
     - ansible_service_mgr|default() == "systemd"

tasks/server.yml

@@ -46,7 +46,8 @@
     - (redis_pidfile|dirname).startswith('/var/run') or (redis_pidfile|dirname).startswith('/run')
 
 - name: reload systemd daemon
-  command: systemctl daemon-reload
+  systemd:
+    daemon_reload: true
   when:
     - redis_as_service
     - ansible_service_mgr|default() == "systemd"